third_party/closure_compiler/compile2.py - Issue 2930773003: Closure compilation: Modify compile_js2.py to not swallow errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/closure_compiler/compile2.py

Issue 2930773003: Closure compilation: Modify compile_js2.py to not swallow errors. (Closed)

Patch Set: Smaller diff. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/closure_compiler/compile2.py

diff --git a/third_party/closure_compiler/compile2.py b/third_party/closure_compiler/compile2.py

index 224856d7227192fd022b0f655d4574c414254349..a237f4b71141d44d04c2d2a472d0cc52c56085bf 100755

--- a/third_party/closure_compiler/compile2.py

+++ b/third_party/closure_compiler/compile2.py

@@ -243,7 +243,7 @@ class Checker(object):

self._log_debug("Args: %s" % " ".join(args))

- _, stderr = self.run_jar(self._compiler_jar, args)

+ return_code, stderr = self.run_jar(self._compiler_jar, args)

errors = stderr.strip().split("\n\n")

maybe_summary = errors.pop()

@@ -280,7 +280,7 @@ class Checker(object):

self._log_debug("Output: %s" % output)

self._nuke_temp_files()

- return bool(errors), stderr

+ return bool(errors) or return_code > 0, stderr

if __name__ == "__main__":

« no previous file with comments | « no previous file | no next file » | no next file with comments »