[iOS Clean] Added HTTP authentication dialog support.

ios/clean/chrome/browser/ui/dialogs/http_auth_dialogs/http_auth_dialog_state.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CLEAN_CHROME_BROWSER_UI_DIALOGS_HTTP_AUTH_DIALOGS_HTTP_AUTH_DIALOG_STATE_H_
+#define IOS_CLEAN_CHROME_BROWSER_UI_DIALOGS_HTTP_AUTH_DIALOGS_HTTP_AUTH_DIALOG_STATE_H_
+
+#import <Foundation/Foundation.h>
+
+namespace web {
+class WebState;
+}
+
+// Block type for HTTP authentication callbacks.
+typedef void (^HTTPAuthDialogCallback)(NSString* username, NSString* password);
+
+// A container object encapsulating all the state necessary to support an

[marq (ping after 24h), 2017/06/14 11:19:15]

Name quibbles -- I'm not wild about "State", because it implies the state may
change at some point. Maybe HTTPAuthDialogRequest?

[kkhorimoto, 2017/06/23 06:25:41]

Done.

+// HTTPAuthDialogCoordiantor.  This object also owns the WebKit
+// completion block that will throw an exception if it is deallocated before
+// being executed. |-runCallbackWithUserName:password:| must be executed once in
+// the lifetime of every JavaScriptDialogState.

[marq (ping after 24h), 2017/06/14 11:19:16]

HTTPAuthDialogState, here an elsewhere. Careful with that (copy/paste errors) in
general.

Should this class and JSDialogState share a parent class?

[kkhorimoto, 2017/06/23 06:25:41]

Fixed.  I don't think they should share a superclass since the thing shared
between them is that they both have a WebState.  They both have similar
purposes, but are different enough that forcing them to have a superclass would
add complexity in the object hierarchy without actually improving it IMO.

+@interface HTTPAuthDialogState : NSObject
+
+// Factory method to create JavaScriptDialogStates from the given input.
++ (instancetype)stateWithWebState:(web::WebState*)webState
+                  protectionSpace:(NSURLProtectionSpace*)protectionSpace
+                       credential:(NSURLCredential*)credential
+                         callback:(HTTPAuthDialogCallback)callback;
+
+// The WebState displaying this dialog.
+@property(nonatomic, readonly) web::WebState* webState;
+
+// The title to use for the dialog.
+@property(nonatomic, readonly) NSString* title;

[marq (ping after 24h), 2017/06/14 11:19:15]

You're marking other readonly string properties as strong elsewhere; be
consistent here.

[kkhorimoto, 2017/06/23 06:25:41]

Done.

+
+// The authentication message for the dialog's protection space.
+@property(nonatomic, readonly, strong) NSString* message;
+
+// The default text to display in the username text field.
+@property(nonatomic, readonly, strong) NSString* defaultUserNameText;
+
+// Calls the callback passed on initialization with the provided parameters.

[marq (ping after 24h), 2017/06/14 11:19:15]

I regard the callback as an implementation detail. Can it be
'completeAuthenticationWith...'.

The semantics of nil username and password should be documented here.

[kkhorimoto, 2017/06/23 06:25:41]

Done.

+- (void)runCallbackWithUserName:(NSString*)username
+                       password:(NSString*)password;
+
+@end
+
+#endif  // IOS_CLEAN_CHROME_BROWSER_UI_DIALOGS_HTTP_AUTH_DIALOGS_HTTP_AUTH_DIALOG_STATE_H_