Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 2930723002: Port a missed piece to remove invalid reference to analysis_server (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
scheglov, danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Port a missed piece to remove invalid reference to analysis_server R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/9b0a98fd4281427f207eb2719b576ba799ba2633

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -16 lines) Patch
A pkg/analyzer_plugin/lib/src/utilities/completion/element_suggestion_builder.dart View 1 chunk +114 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/lib/utilities/completion/inherited_reference_contributor.dart View 3 chunks +5 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 6 months ago (2017-06-07 16:49:58 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-07 16:54:55 UTC) #3
Brian Wilkerson
3 years, 6 months ago (2017-06-07 17:06:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9b0a98fd4281427f207eb2719b576ba799ba2633 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698