Implement initializer asserts.

Implement initializer asserts.

Closes https://github.com/dart-lang/sdk/issues/29762

R=kasperl@google.com

Committed: https://github.com/dart-lang/sdk/commit/001ac9738937019992cce68c638ead344a6268fc

[ahe, 2017-06-07 16:25:44]

ahe@google.com changed reviewers:
+ kasperl@google.com, lrn@google.com

[ahe, 2017-06-07 16:27:33]

Description was changed from

==========
Implement initializer asserts.
==========

to

==========
Implement initializer asserts.

Closes https://github.com/dart-lang/sdk/issues/29762
==========

[kasperl, 2017-06-08 10:23:14]

LGTM!

https://codereview.chromium.org/2930673002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2930673002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:2455: inInitializer =
false;
Add a comment to explain why you have to turn this off. When is the previous
value restored? In endInitializer?

https://codereview.chromium.org/2930673002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:2481: return new
LocalInitializer(new VariableDeclaration.forValue(
It would be useful if you could explain the structure of the initializer you're
building here in a comment.

https://codereview.chromium.org/2930673002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2930673002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:3825:
reportRecoverableErrorCode(firstExtra, codeAssertExtraneousArgument);
Very nice to see the recoverable errors being dealt with! Do we have test that
cover that?

https://codereview.chromium.org/2930673002/diff/1/tests/language/language_ker...
File tests/language/language_kernel.status (right):

https://codereview.chromium.org/2930673002/diff/1/tests/language/language_ker...
tests/language/language_kernel.status:354: assert_initializer_test/31:
MissingCompileTimeError
Is this a Fasta bug related to compile-time constant evaluation?

[ahe, 2017-06-08 11:04:34]

Thank you, Kasper!

I've tweaked the definitions of the error codes so that dart2js treats these
recoverable errors as fatal. Otherwise, I'd have to implement support for
asserts as expressions in dart2js.

In addition, I had forgotten to override handleExtraneousExpression, which made
fasta crash on co19/Language/Functions/syntax_t23.

https://codereview.chromium.org/2930673002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2930673002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:2455: inInitializer =
false;
On 2017/06/08 10:23:14, kasperl wrote:
> Add a comment to explain why you have to turn this off. When is the previous
> value restored? In endInitializer?

This value is never restored. I've added a comment here and on the declaration
of inInitializer.

https://codereview.chromium.org/2930673002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:2481: return new
LocalInitializer(new VariableDeclaration.forValue(
On 2017/06/08 10:23:14, kasperl wrote:
> It would be useful if you could explain the structure of the initializer
you're
> building here in a comment.

Done.

https://codereview.chromium.org/2930673002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2930673002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:3825:
reportRecoverableErrorCode(firstExtra, codeAssertExtraneousArgument);
On 2017/06/08 10:23:14, kasperl wrote:
> Very nice to see the recoverable errors being dealt with! Do we have test that
> cover that?

Yes. At least these tests:

co19/Language/Statements/Assert/syntax_t04
co19/Language/Functions/syntax_t23

https://codereview.chromium.org/2930673002/diff/1/tests/language/language_ker...
File tests/language/language_kernel.status (right):

https://codereview.chromium.org/2930673002/diff/1/tests/language/language_ker...
tests/language/language_kernel.status:354: assert_initializer_test/31:
MissingCompileTimeError
On 2017/06/08 10:23:14, kasperl wrote:
> Is this a Fasta bug related to compile-time constant evaluation?

32-38 and none are due to this comment:

  // Functions not allowed in asserts in const execution.

So it boils down to runtime const evaluation.

41-48 try to assert something that isn't a boolean or a function.

So they also boil down to runtime const evaluation.

I'll add comments about this.

[ahe, 2017-06-08 11:46:31]

Description was changed from

==========
Implement initializer asserts.

Closes https://github.com/dart-lang/sdk/issues/29762
==========

to

==========
Implement initializer asserts.

Closes https://github.com/dart-lang/sdk/issues/29762

R=kasperl@google.com

Committed:
https://github.com/dart-lang/sdk/commit/001ac9738937019992cce68c638ead344a6268fc
==========

[ahe, 2017-06-08 11:46:33]

Committed patchset #2 (id:20001) manually as
001ac9738937019992cce68c638ead344a6268fc (presubmit successful).