Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6976)

Unified Diff: chrome/browser/resources/options/cookies_view.js

Issue 293063017: Updated to read remove all shown when the user searches for a cookie (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/webui/options/cookies_view_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/cookies_view.js
diff --git a/chrome/browser/resources/options/cookies_view.js b/chrome/browser/resources/options/cookies_view.js
index 4d496684c428f87e17841876cdf7252ac3be9fa6..b0fadaad7075ac5c30f3970c9cbbc44afbd56f93 100644
--- a/chrome/browser/resources/options/cookies_view.js
+++ b/chrome/browser/resources/options/cookies_view.js
@@ -88,6 +88,15 @@ cr.define('options', function() {
* @private
*/
handleSearchQueryChange_: function(e) {
+ var content = document.querySelector('.cookies-search-box').value.trim();
+ if (content) {
+ document.querySelector('.remove-all-cookies-button').innerHTML =
felt 2014/05/23 17:18:12 Instead of using innerHTML, can you use .value?
felt 2014/05/23 22:40:14 Radhika's response was:
+ loadTimeData.getString('remove_all_shown_cookie');
+ }
+ else {
+ document.querySelector('.remove-all-cookies-button').innerHTML =
+ loadTimeData.getString('remove_all_cookie');
+ }
if (this.queryDelayTimerId_)
window.clearTimeout(this.queryDelayTimerId_);
@@ -107,14 +116,12 @@ cr.define('options', function() {
return;
chrome.send('reloadCookies');
-
felt 2014/05/23 17:18:12 did you intentionally delete these lines?
if (!this.initialized_) {
this.initialized_ = true;
this.searchCookie();
} else {
this.pageDiv.querySelector('.cookies-list').redraw();
}
-
this.pageDiv.querySelector('.cookies-search-box').focus();
},
};
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/webui/options/cookies_view_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698