Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 293063015: Bluetooth: remove Out of Band Pairing APIs (Closed)

Created:
6 years, 7 months ago by keybuk
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Tim Song
Visibility:
Public.

Description

Bluetooth: remove Out of Band Pairing APIs These is no platform implementation, with no available APIs on at least Chrome OS and OS X to implement these, and Android does not support Out of Band Pairing. Thus remove the APIs, they can always be put back later if we find an implementation. BUG=376492 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273136

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -442 lines) Patch
M chrome/browser/extensions/api/bluetooth/bluetooth_api.h View 2 chunks +0 lines, -33 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_api.cc View 3 chunks +0 lines, -106 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_apitest.cc View 4 chunks +0 lines, -106 lines 0 comments Download
M chrome/common/extensions/api/bluetooth.idl View 4 chunks +0 lines, -34 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_adapter.h View 3 chunks +0 lines, -12 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_chromeos.h View 1 chunk +0 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_chromeos.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_mac.h View 1 chunk +0 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_mac.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_win.h View 1 chunk +0 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_win.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M device/bluetooth/bluetooth_device.h View 2 chunks +0 lines, -15 lines 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.h View 1 chunk +0 lines, -7 lines 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M device/bluetooth/bluetooth_device_mac.h View 1 chunk +0 lines, -7 lines 0 comments Download
M device/bluetooth/bluetooth_device_mac.mm View 2 chunks +0 lines, -14 lines 0 comments Download
M device/bluetooth/bluetooth_device_win.h View 1 chunk +0 lines, -7 lines 0 comments Download
M device/bluetooth/bluetooth_device_win.cc View 2 chunks +0 lines, -14 lines 0 comments Download
D device/bluetooth/bluetooth_out_of_band_pairing_data.h View 1 chunk +0 lines, -27 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_adapter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_device.h View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
keybuk
kalman, miket: for bluetooth.idl OWNERS others: general LGTM
6 years, 7 months ago (2014-05-22 21:35:02 UTC) #1
not at google - send to devlin
idl lgtm
6 years, 7 months ago (2014-05-22 21:37:57 UTC) #2
miket_OOO
idl LGTM
6 years, 7 months ago (2014-05-22 22:50:00 UTC) #3
armansito
lgtm
6 years, 7 months ago (2014-05-27 23:31:41 UTC) #4
keybuk
The CQ bit was checked by keybuk@chromium.org
6 years, 7 months ago (2014-05-27 23:42:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/293063015/1
6 years, 7 months ago (2014-05-27 23:43:40 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 03:10:17 UTC) #7
Message was sent while issue was closed.
Change committed as 273136

Powered by Google App Engine
This is Rietveld 408576698