Issue 293063013: Now that the HttpStreamFactoryImpl::Job is not marking Alternate-Protocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 293063013: Now that the HttpStreamFactoryImpl::Job is not marking Alternate-Protocol (Closed)

Created:
6 years, 7 months ago by Ryan Hamilton

Modified:
6 years, 7 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Now that the HttpStreamFactoryImpl::Job is not marking Alternate-Protocol as broken unless the main job succeeds, do not mark Alternate-Protocol broken in the QuicStreamFactory unless the session was a failed 0-RTT connection (in which case the Job already "succeeded"). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272442

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : better test #

Total comments: 1

Patch Set 4 : fix comments #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -28 lines)			Patch
M	net/http/http_stream_factory_impl_job.cc	View		2 chunks	+12 lines, -9 lines	0 comments	Download
M	net/quic/quic_network_transaction_unittest.cc	View	1 2	3 chunks	+5 lines, -5 lines	0 comments	Download
M	net/quic/quic_stream_factory.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	net/quic/quic_stream_factory.cc	View	1 2 3	3 chunks	+17 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

LGTM % discussed nit https://codereview.chromium.org/293063013/diff/40001/net/quic/quic_stream_factory.cc File net/quic/quic_stream_factory.cc (right): https://codereview.chromium.org/293063013/diff/40001/net/quic/quic_stream_factory.cc#newcode831 net/quic/quic_stream_factory.cc:831: } nit: return

6 years, 7 months ago (2014-05-22 21:03:22 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/293063013/60001

6 years, 7 months ago (2014-05-22 21:06:05 UTC) #4

Message was sent while issue was closed.

Change committed as 272442

Expand Messages | Collapse Messages