Multiple account support in chrome.identity.getAuthToken

chrome/common/extensions/api/identity.idl

Index: chrome/common/extensions/api/identity.idl
diff --git a/chrome/common/extensions/api/identity.idl b/chrome/common/extensions/api/identity.idl
index a4893b25e826637ef624fb537f2cb99e53a00f02..1178769caae682ab3d6b5966d382bb91016d2d2f 100644
--- a/chrome/common/extensions/api/identity.idl
+++ b/chrome/common/extensions/api/identity.idl
@@ -5,6 +5,12 @@
 // Use the <code>chrome.identity</code> API to get OAuth2 access tokens.
 namespace identity {
 
+  dictionary AccountInfo {
+    // A unique identifier for the account. This ID will not change

[fgorski, 2014/06/03 23:46:41]

nit: s/the/an/ perhaps?

[Michael Courage, 2014/06/04 23:37:38]

The id is for the specific account described by the AccountInfo, so I like
"the".

+    // for the lifetime of the account.
+    DOMString id;
+  };
+
   dictionary TokenDetails {
     // Fetching a token may require the user to sign-in to Chrome, or
     // approve the application's requested scopes. If the interactive
@@ -13,6 +19,13 @@ namespace identity {
     // <code>false</code> or omitted, <code>getAuthToken</code> will
     // return failure any time a prompt would be required.
     boolean? interactive;
+
+    // The account ID whose token should be returned. If not
+    // specified, the primary account for the profile will be used.
+    //
+    // <code>account</code> is only supported when the
+    // "new-profile-management" flag is set.

[fgorski, 2014/06/03 23:46:41]

I'd give it the whole name of the flag: #enable-new-profile-management, but it's
up to you.

[Michael Courage, 2014/06/04 23:37:38]

Done.

+    AccountInfo? account;
   };
 
   dictionary InvalidTokenDetails {
@@ -39,12 +52,6 @@ namespace identity {
     boolean? interactive;
   };
 
-  dictionary AccountInfo {
-    // A unique identifier for the account. This ID will not change
-    // for the lifetime of the account.
-    DOMString id;
-  };
-
   callback GetAuthTokenCallback = void (optional DOMString token);
   callback GetAccountsCallback = void (AccountInfo[] accounts);
   callback InvalidateAuthTokenCallback = void ();