Multiple account support in chrome.identity.getAuthToken

Multiple account support in chrome.identity.getAuthToken

This change adds an optional "account" field in the TokenDetails
parameter to getAuthToken. When this field is populated with an object
identifying a valid account signed in on the current profile,
getAuthToken will return a token for the specified account.

When the parameter is not present, getAuthToken behaves as before,
returning tokens for the primary profile user.

BUG=258515
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275173

[Michael Courage, 2014-05-29 21:09:35]

fgorski: chrome/browser/extensions/api/identity/*
kalman: chrome/common/extensions/api/identity.idl

Another piece of the designed-long-ago multi-login identity API.

[not at google - send to devlin, 2014-05-29 21:11:06]

lgtm

https://codereview.chromium.org/293063002/diff/70001/chrome/common/extensions...
File chrome/common/extensions/api/identity.idl (right):

https://codereview.chromium.org/293063002/diff/70001/chrome/common/extensions...
chrome/common/extensions/api/identity.idl:27: // "new-profile-management" is
set.
the word "flag" seems left out

[fgorski, 2014-06-03 23:46:41]

lgtm

https://codereview.chromium.org/293063002/diff/90001/chrome/browser/extension...
File chrome/browser/extensions/api/identity/identity_api.cc (right):

https://codereview.chromium.org/293063002/diff/90001/chrome/browser/extension...
chrome/browser/extensions/api/identity/identity_api.cc:680: // TODO(courage):
figure out what account should be here
I'd check with bartfab, but based on my exchange with him re: gcm services, it
should be whatever comes from identity provider. (as in the device case it would
use robot account) -> qualified guess

https://codereview.chromium.org/293063002/diff/90001/chrome/browser/extension...
File chrome/browser/extensions/api/identity/identity_apitest.cc (right):

https://codereview.chromium.org/293063002/diff/90001/chrome/browser/extension...
chrome/browser/extensions/api/identity/identity_apitest.cc:1461:
IN_PROC_BROWSER_TEST_F(GetAuthTokenFunctionTest, MultiSecondaryUser) {
are you planning to add negative tests for secondary users?

https://codereview.chromium.org/293063002/diff/90001/chrome/common/extensions...
File chrome/common/extensions/api/identity.idl (right):

https://codereview.chromium.org/293063002/diff/90001/chrome/common/extensions...
chrome/common/extensions/api/identity.idl:9: // A unique identifier for the
account. This ID will not change
nit: s/the/an/ perhaps?

https://codereview.chromium.org/293063002/diff/90001/chrome/common/extensions...
chrome/common/extensions/api/identity.idl:27: // "new-profile-management" flag
is set.
I'd give it the whole name of the flag: #enable-new-profile-management, but it's
up to you.

[Michael Courage, 2014-06-04 23:37:37]

https://codereview.chromium.org/293063002/diff/90001/chrome/browser/extension...
File chrome/browser/extensions/api/identity/identity_api.cc (right):

https://codereview.chromium.org/293063002/diff/90001/chrome/browser/extension...
chrome/browser/extensions/api/identity/identity_api.cc:680: // TODO(courage):
figure out what account should be here
On 2014/06/03 23:46:40, fgorski wrote:
> I'd check with bartfab, but based on my exchange with him re: gcm services, it
> should be whatever comes from identity provider. (as in the device case it
would
> use robot account) -> qualified guess

Right thing to do here is use the account established in RunAsync. Right now it
does no kiosk specific filtering, and I don't think it needs to.

https://codereview.chromium.org/293063002/diff/90001/chrome/browser/extension...
File chrome/browser/extensions/api/identity/identity_apitest.cc (right):

https://codereview.chromium.org/293063002/diff/90001/chrome/browser/extension...
chrome/browser/extensions/api/identity/identity_apitest.cc:1461:
IN_PROC_BROWSER_TEST_F(GetAuthTokenFunctionTest, MultiSecondaryUser) {
On 2014/06/03 23:46:41, fgorski wrote:
> are you planning to add negative tests for secondary users?

TODO added

https://codereview.chromium.org/293063002/diff/90001/chrome/common/extensions...
File chrome/common/extensions/api/identity.idl (right):

https://codereview.chromium.org/293063002/diff/90001/chrome/common/extensions...
chrome/common/extensions/api/identity.idl:9: // A unique identifier for the
account. This ID will not change
On 2014/06/03 23:46:41, fgorski wrote:
> nit: s/the/an/ perhaps?

The id is for the specific account described by the AccountInfo, so I like
"the".

https://codereview.chromium.org/293063002/diff/90001/chrome/common/extensions...
chrome/common/extensions/api/identity.idl:27: // "new-profile-management" flag
is set.
On 2014/06/03 23:46:41, fgorski wrote:
> I'd give it the whole name of the flag: #enable-new-profile-management, but
it's
> up to you.

Done.

[Michael Courage, 2014-06-04 23:37:42]

The CQ bit was checked by courage@chromium.org

[commit-bot: I haz the power, 2014-06-04 23:38:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/courage@chromium.org/293063002/130001

[commit-bot: I haz the power, 2014-06-05 05:01:26]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[commit-bot: I haz the power, 2014-06-05 05:08:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 05:08:17]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[Michael Courage, 2014-06-05 16:53:51]

The CQ bit was checked by courage@chromium.org

[commit-bot: I haz the power, 2014-06-05 16:56:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/courage@chromium.org/293063002/130001

[commit-bot: I haz the power, 2014-06-05 17:18:05]

Change committed as 275173