Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2102)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

Issue 2930553002: Add UMA metric to track the time elapsed since a WebAPK was last launched (Closed)
Patch Set: Merge branch 'master' into last_launched Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
index c4d55b511995c8125fbede9e250d66319866d5ca..2102df9d6fb1668063677ea5c92275187252afef 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
@@ -182,6 +182,16 @@ public class WebApkActivity extends WebappActivity {
maybeShowDisclosure(storage);
}
+ @Override
+ protected void onWillUpdateLastUsedTime(WebappDataStorage storage) {
+ super.onWillUpdateLastUsedTime(storage);
+
+ long lastUsedMs = storage.getLastUsedTime();
+ if (storage.wasLaunched()) {
+ WebApkUma.recordLaunchInterval(lastUsedMs - storage.getLastUsedTime());
Xi Han 2017/06/09 14:55:35 I am confused here. Do you expect the |LastUsedTim
pkotwicz 2017/06/12 20:34:46 Thank you for catching this bug!
+ }
+ }
+
/**
* If we're showing a WebApk that's not with an expected package, it must be an
* "Unbound WebApk" (crbug.com/714735) so show a notification that it's running in Chrome.

Powered by Google App Engine
This is Rietveld 408576698