Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 293055: Fix calculation of length in websocket.cc. (Closed)

Created:
11 years, 2 months ago by Craig
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix calculation of length in websocket.cc. The compiler warned about this. See http://tools.ietf.org/html/draft-hixie-thewebsocketprotocol-49#section-4.2 for how to calculate the length. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/websockets/websocket.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Craig
Please review. Thank you.
11 years, 2 months ago (2009-10-21 19:03:47 UTC) #1
ukai
LGTM
11 years, 2 months ago (2009-10-22 01:19:36 UTC) #2
darin (slow to review)
Shouldn't there have been a unit test for this?
11 years, 2 months ago (2009-10-22 06:40:56 UTC) #3
ukai
On 2009/10/22 06:40:56, darin wrote: > Shouldn't there have been a unit test for this? ...
11 years, 2 months ago (2009-10-22 06:42:54 UTC) #4
darin (slow to review)
Every code change that impacts the behavior of the code, I mean :) On Wed, ...
11 years, 2 months ago (2009-10-22 06:57:15 UTC) #5
darin (slow to review)
11 years, 2 months ago (2009-10-22 06:59:38 UTC) #6
Thanks!  (Every code change should have a test.)

On Wed, Oct 21, 2009 at 11:42 PM, <ukai@chromium.org> wrote:

> On 2009/10/22 06:40:56, darin wrote:
>
>> Shouldn't there have been a unit test for this?
>>
>
> Sure. I'll add unit tests.
>
>
> http://codereview.chromium.org/293055
>

Powered by Google App Engine
This is Rietveld 408576698