Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 293053014: Retrieve chrome build info in GCMProfileService, instead of GCMDriver (Closed)

Created:
6 years, 7 months ago by jianli
Modified:
6 years, 7 months ago
Reviewers:
Nicolas Zea, fgorski
CC:
chromium-reviews
Visibility:
Public.

Description

Retrieve chrome build info in GCMProfileService, instead of GCMDriver Since GCMDriver is going to be moved into component, it cannot access chrome build info. So we now let GCMProfileService retrieve and pass it. Also change to define build info in GCMClient, instead of relying on the one defined in proto buffer generated file. BUG=356716 TEST=existing tests Patch Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272453

Patch Set 1 #

Patch Set 2 : Fix trybots #

Patch Set 3 : Sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -68 lines) Patch
M chrome/browser/services/gcm/fake_gcm_client.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/services/gcm/fake_gcm_client.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/services/gcm/gcm_driver.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/services/gcm/gcm_driver.cc View 1 2 6 chunks +5 lines, -52 lines 0 comments Download
M chrome/browser/services/gcm/gcm_driver_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/browser/services/gcm/gcm_utils.h View 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/browser/services/gcm/gcm_utils.cc View 1 chunk +67 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M google_apis/gcm/gcm_client.h View 1 4 chunks +29 lines, -6 lines 0 comments Download
M google_apis/gcm/gcm_client.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M google_apis/gcm/gcm_client_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gcm/gcm_client_impl.cc View 1 6 chunks +68 lines, -4 lines 0 comments Download
M google_apis/gcm/gcm_client_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jianli
6 years, 7 months ago (2014-05-22 17:48:49 UTC) #1
fgorski
lgtm
6 years, 7 months ago (2014-05-22 19:12:31 UTC) #2
Nicolas Zea
lgtm
6 years, 7 months ago (2014-05-22 20:16:08 UTC) #3
jianli
The CQ bit was checked by jianli@chromium.org
6 years, 7 months ago (2014-05-22 20:40:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/293053014/40001
6 years, 7 months ago (2014-05-22 20:43:01 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 07:09:50 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 09:40:50 UTC) #7
Message was sent while issue was closed.
Change committed as 272453

Powered by Google App Engine
This is Rietveld 408576698