|
Retrieve chrome build info in GCMProfileService, instead of GCMDriver
Since GCMDriver is going to be moved into component, it cannot access
chrome build info. So we now let GCMProfileService retrieve and pass
it.
Also change to define build info in GCMClient, instead of relying on
the one defined in proto buffer generated file.
BUG= 356716
TEST=existing tests
Patch
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272453
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+206 lines, -68 lines) |
Patch |
 |
M |
chrome/browser/services/gcm/fake_gcm_client.h
|
View
|
1
2
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/services/gcm/fake_gcm_client.cc
|
View
|
1
2
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/services/gcm/gcm_driver.h
|
View
|
1
2
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/services/gcm/gcm_driver.cc
|
View
|
1
2
|
6 chunks |
+5 lines, -52 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/services/gcm/gcm_driver_unittest.cc
|
View
|
1
2
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/services/gcm/gcm_profile_service.cc
|
View
|
1
2
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/services/gcm/gcm_utils.h
|
View
|
|
1 chunk |
+17 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/services/gcm/gcm_utils.cc
|
View
|
|
1 chunk |
+67 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_browser.gypi
|
View
|
1
2
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
google_apis/gcm/gcm_client.h
|
View
|
1
|
4 chunks |
+29 lines, -6 lines |
0 comments
|
Download
|
 |
M |
google_apis/gcm/gcm_client.cc
|
View
|
|
1 chunk |
+8 lines, -0 lines |
0 comments
|
Download
|
 |
M |
google_apis/gcm/gcm_client_impl.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
google_apis/gcm/gcm_client_impl.cc
|
View
|
1
|
6 chunks |
+68 lines, -4 lines |
0 comments
|
Download
|
 |
M |
google_apis/gcm/gcm_client_impl_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
Total messages: 7 (0 generated)
|