Issue 293053011: Mojo: Mojom: Fix line number tracking when there are comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 293053011: Mojo: Mojom: Fix line number tracking when there are comments. (Closed)

Created:
6 years, 7 months ago by viettrungluu

Modified:
6 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Mojom: Fix line number tracking when there are comments. Currently, we don't track line numbers correctly in multi-line C-style comments (/* ... */) and when there are consecutive lines with (only) C++-style comments. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272007

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -2 lines)			Patch
	M	mojo/public/tools/bindings/pylib/mojom/parse/lexer.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	mojo/public/tools/bindings/pylib/mojom_tests/parse/parser_unittest.py	View		1 chunk	+61 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

6 years, 7 months ago (2014-05-21 23:14:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r272007 (presubmit successful).

Expand Messages | Collapse Messages