Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 293053009: Whitelist experimental bookmarks extension on stable. (Closed)

Created:
6 years, 7 months ago by Rune Fevang
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Whitelist experimental bookmarks extension on stable. preferencesPrivate was only available on the dev channel. This CL moves the whitelist entries to a stable channel entry. BUG=312900, 319444, 371562, 375938 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272087

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/common/extensions/api/_permission_features.json View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Rune Fevang
6 years, 7 months ago (2014-05-21 19:03:32 UTC) #1
not at google - send to devlin
https://codereview.chromium.org/293053009/diff/1/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/293053009/diff/1/chrome/common/extensions/api/_permission_features.json#newcode712 chrome/common/extensions/api/_permission_features.json:712: "channel": "dev", let's just change this to "stable", weird ...
6 years, 7 months ago (2014-05-21 20:11:26 UTC) #2
Rune Fevang
https://codereview.chromium.org/293053009/diff/1/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/293053009/diff/1/chrome/common/extensions/api/_permission_features.json#newcode712 chrome/common/extensions/api/_permission_features.json:712: "channel": "dev", On 2014/05/21 20:11:27, kalman wrote: > let's ...
6 years, 7 months ago (2014-05-21 20:18:28 UTC) #3
not at google - send to devlin
lgtm The only extension in the universe that uses that API is.. you :)
6 years, 7 months ago (2014-05-21 20:24:59 UTC) #4
Rune Fevang
The CQ bit was checked by rfevang@chromium.org
6 years, 7 months ago (2014-05-21 20:30:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rfevang@chromium.org/293053009/20001
6 years, 7 months ago (2014-05-21 20:34:07 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 04:08:23 UTC) #7
Message was sent while issue was closed.
Change committed as 272087

Powered by Google App Engine
This is Rietveld 408576698