LayoutTests/fast/dom/resources/set-frame-src-while-running-script-in-frame.html - Issue 293053007: V8AbstractEventListener should hold a ScriptState

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/resources/set-frame-src-while-running-script-in-frame.html

Issue 293053007: V8AbstractEventListener should hold a ScriptState (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 <html>

2 <script>

3 var f = parent.document.getElementsByTagName('iframe')[0]

4 f.onload = function() { if (window.testRunner) testRunner.notifyDone(); }

5 f.src="about:blank"
haraken 2014/05/29 05:50:39 This test is testing the following things. (1) f. This test is testing the following things. (1) f.onload sets the event listener on this frame (say Frame1). (2) f.src="about:blank" is loaded into this iframe. A new Frame object is created (say Frame2). (3) f.onload is called. The test is checking if it doesn't crash. Before this CL, this sequence was working because when we were invoking f.onload using the ExecutionContext of Frame2. (i.e., V8AbstractEventListener::invokeEventHandler) After this CL, f.onload is not called because we try to invoke f.onload using the ExecutionContext of Frame1. This is because we store the current ScriptState in (1) and use the ScriptState's executionContext in (3). Because the Frame1 is already gone, we cannot call f.onload. (i.e., V8AbstractEventListener::invokeEventHandler returns before invoking the event listener.) - I think the new behavior is more reasonable. - I confirmed that Firefox aligns with the new behavior. - As far as I know, the behavior is not speced (there is a W3C bug: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24403). Given the above, this CL makes the behavior change and removes this test (because this test is no longer testing something meaningful).
6 </script>

7 </html>

OLD	NEW