Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(9)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: LayoutTests/fast/dom/set-frame-src-while-running-script-in-frame.html
Issue
293053007
:
V8AbstractEventListener should hold a ScriptState (Closed)
Base URL: svn://svn.chromium.org/blink/trunk
Patch Set:
Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/fast/dom/resources/set-frame-src-while-running-script-in-frame.html
LayoutTests/fast/dom/resources/xmlhttprequest-constructor-in-detached-document-frame.html
LayoutTests/fast/dom/set-frame-src-while-running-script-in-frame.html
LayoutTests/fast/dom/xmlhttprequest-constructor-in-detached-document.html
Source/bindings/scripts/v8_attributes.py
Source/bindings/v8/V8AbstractEventListener.h
Source/bindings/v8/V8AbstractEventListener.cpp
Source/bindings/v8/V8ErrorHandler.h
Source/bindings/v8/V8ErrorHandler.cpp
Source/bindings/v8/V8EventListener.h
Source/bindings/v8/V8EventListener.cpp
Source/bindings/v8/V8EventListenerList.h
Source/bindings/v8/V8EventListenerList.cpp
Source/bindings/v8/V8LazyEventListener.h
Source/bindings/v8/V8LazyEventListener.cpp
Source/bindings/v8/V8WorkerGlobalScopeEventListener.h
Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp
Source/web/tests/CustomEventTest.cpp
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« LayoutTests/fast/dom/resources/xmlhttprequest-constructor-in-detached-document-frame.html
('k') |
LayoutTests/fast/dom/xmlhttprequest-constructor-in-detached-document.html »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<html>
2
<script>
3
if (window.testRunner) {
4
testRunner.dumpAsText();
5
testRunner.waitUntilDone();
6
}
7
</script>
8
<iframe src="resources/set-frame-src-while-running-script-in-frame.html"></ifram e>
9
<body>
10
<p>This tests that a frame can set its src to "about:blank" while running inside a <script> without an assertion failing.</p>
11
<p>SUCCESS - Didn't crash!</p>
12
</body>
13
</html>
OLD
NEW
« no previous file with comments
|
« LayoutTests/fast/dom/resources/xmlhttprequest-constructor-in-detached-document-frame.html
('k') |
LayoutTests/fast/dom/xmlhttprequest-constructor-in-detached-document.html »
('j') |
no next file with comments »
Issue 293053007: V8AbstractEventListener should hold a ScriptState (Closed)
Created 6 years, 7 months ago by haraken
Modified 6 years, 6 months ago
Reviewers: dcarney, adamk, tasak
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 4
This is Rietveld
408576698