Issue 293049: Fix compatibility problems with FileZilla FTP Server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 293049: Fix compatibility problems with FileZilla FTP Server. (Closed)

Created:
11 years, 2 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
eroman, wtc

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix compatibility problems with FileZilla FTP Server. TEST=Covered by net_unittests. BUG=25316 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29662

Patch Set 1 #

Total comments: 2

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -8 lines)			Patch
	M	net/ftp/ftp_network_transaction.cc	View		1 chunk	+4 lines, -2 lines	1 comment	Download
	M	net/ftp/ftp_network_transaction_unittest.cc	View		8 chunks	+27 lines, -6 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eroman

lgtm http://codereview.chromium.org/293049/diff/1/3 File net/ftp/ftp_network_transaction_unittest.cc (right): http://codereview.chromium.org/293049/diff/1/3#newcode528 Line 528: // socket for directory requests. For more ...

11 years, 2 months ago (2009-10-21 16:57:52 UTC) #2

wtc

11 years, 2 months ago (2009-10-22 22:15:29 UTC) #3

LGTM.

http://codereview.chromium.org/293049/diff/1/2
File net/ftp/ftp_network_transaction.cc (right):

http://codereview.chromium.org/293049/diff/1/2#newcode929
Line 929: next_state_ = STATE_CTRL_WRITE_PASV;
It's not clear how we arrange to try CWD after the PASV is
done.

Expand Messages | Collapse Messages