update analyzer parser tests for fasta scanner

update analyzer parser tests for fasta scanner

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/b0374f214c704b4da0e1102f806ace7fc9518d3a

[danrubel, 2017-06-06 11:26:50]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2017-06-06 14:00:18]

I don't expect this to break anything and I don't want to hold you up, so lgtm,
but I really think we should back out this kind of recovery.

https://codereview.chromium.org/2930453002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/parser.dart (right):

https://codereview.chromium.org/2930453002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/parser.dart:1279: (_isOperator(next) || next.type
== TokenType.EQ_EQ_EQ)) {
What is "==="?

That operator hasn't been part of the language for a long time, so I'm guessing
that this is here for recovery. But is there any reason to think that there's
value in supporting this kind of recovery? There have not been any issues that
I'm aware of where people were confused by its absence. I think it would be
better to keep the code cleaner rather than add recovery for a rare case.

If we really think this is useful, then we should document (in the fasta parser,
presumably) that this support is here for recovery purposes.

[danrubel, 2017-06-07 15:03:47]

https://codereview.chromium.org/2930453002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/parser.dart (right):

https://codereview.chromium.org/2930453002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/parser.dart:1279: (_isOperator(next) || next.type
== TokenType.EQ_EQ_EQ)) {
On 2017/06/06 14:00:17, Brian Wilkerson wrote:
> What is "==="?
> 
> That operator hasn't been part of the language for a long time, so I'm
guessing
> that this is here for recovery. But is there any reason to think that there's
> value in supporting this kind of recovery? There have not been any issues that
> I'm aware of where people were confused by its absence. I think it would be
> better to keep the code cleaner rather than add recovery for a rare case.
> 
> If we really think this is useful, then we should document (in the fasta
parser,
> presumably) that this support is here for recovery purposes.

Good question. It exists for the purpose of better recovery. I'll add docs for
the token indicating as much.

[danrubel, 2017-06-07 15:05:49]

Description was changed from

==========
update analyzer parser tests for fasta scanner
==========

to

==========
update analyzer parser tests for fasta scanner

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b0374f214c704b4da0e1102f806ace7fc9518d3a
==========

[danrubel, 2017-06-07 15:05:51]

Committed patchset #1 (id:1) manually as
b0374f214c704b4da0e1102f806ace7fc9518d3a (presubmit successful).