Send UMA recording state to TranslateRanker.

components/translate/core/browser/translate_ranker_impl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/translate/core/browser/translate_ranker_impl.h"
 
 #include <initializer_list>
 #include <memory>
 
 #include "base/feature_list.h"
@@ skipping 332 matching lines @@
   EXPECT_EQ(0U, flushed_events.size());
 
   ranker->RecordTranslateEvent(0, GURL(), &translate_event1_);
   ranker->RecordTranslateEvent(1, GURL(), &translate_event2_);
   ranker->RecordTranslateEvent(2, GURL(), &translate_event3_);
 
   // Logging is enabled by default, so events should be cached.
   ranker->FlushTranslateEvents(&flushed_events);
   EXPECT_EQ(3U, flushed_events.size());
 
-  // Override the feature setting to disable logging.
+  ranker->RecordTranslateEvent(0, GURL(), &translate_event1_);
+  // Override the feature setting to disable logging. The event cache will be
+  // cleared.
   ranker->EnableLogging(false);
 

[Roger McFarlane (Chromium), 2017/06/06 19:28:27]

before and after EnableLogging(), can we assert the cache size?

[hamelphi, 2017/06/06 20:28:06]

Not easily, since the cache is private. However, RecordTranslateEvent and
FlushTranslateEvents are tested a few lines above.

I don't think it warrants exposing the cache just for testing.

-  ranker->RecordTranslateEvent(0, GURL(), &translate_event1_);
   ranker->RecordTranslateEvent(1, GURL(), &translate_event2_);
   ranker->RecordTranslateEvent(2, GURL(), &translate_event3_);
 
   // Logging is disabled, so no events should be cached.
   ranker->FlushTranslateEvents(&flushed_events);
   EXPECT_EQ(0U, flushed_events.size());
 }
 
 TEST_F(TranslateRankerImplTest, ShouldOverrideDecision_OverrideDisabled) {
   InitFeatures({}, {kTranslateRankerDecisionOverride});
@@ skipping 23 matching lines @@
   EXPECT_TRUE(ranker->ShouldOverrideDecision(2, GURL(), &translate_event));
 
   std::vector<metrics::TranslateEventProto> flushed_events;
   ranker->FlushTranslateEvents(&flushed_events);
   EXPECT_EQ(0U, flushed_events.size());
   ASSERT_EQ(2, translate_event.decision_overrides_size());
   ASSERT_EQ(1, translate_event.decision_overrides(0));
   ASSERT_EQ(2, translate_event.decision_overrides(1));
   ASSERT_EQ(0, translate_event.event_type());
 }