Issue 293040: Added a static function pointer to cache the SetActiveURL pointer returned by...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 293040: Added a static function pointer to cache the SetActiveURL pointer returned by... (Closed)

Created:
11 years, 2 months ago by jschuh

Modified:
9 years, 6 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews_googlegroups.com, Chris Evans

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Added a static function pointer to cache the SetActiveURL pointer returned by GetProcAddress() BUG=25366 TEST=Breakpoint the call to SetActiveURL() to ensure that the pointer is cached and called properly.

Patch Set 1 #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
	M	chrome/common/child_process_logging_win.cc	View		1 chunk	+10 lines, -7 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

11 years, 2 months ago (2009-10-21 17:32:26 UTC) #3

http://codereview.chromium.org/293040/diff/1/2
File chrome/common/child_process_logging_win.cc (right):

http://codereview.chromium.org/293040/diff/1/2#newcode26
Line 26: GetProcAddress(exe_module, "SetActiveURL"));
strictly speaking the spacing here is wrong, should be indented 4 spaces, but
don't worry.

Expand Messages | Collapse Messages