Add a device setting that indicates dev mode blocking status.

Add a device setting that indicates dev mode blocking status.

This setting can be configured by device owners to indicate whether
developer mode should be available on their device. session_manager
will take care of configuring the system to behave accordingly.

BUG=chromium:375772
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272502

[Mattias Nissler (ping if slow), 2014-05-22 14:40:31]

Please review:

pastarmovj: Main review
joaodasilva: policy_templates.json
isherman: histograms.xml

[Joao da Silva, 2014-05-22 15:04:07]

policy_templates lgtm after fixing typo

https://codereview.chromium.org/293033012/diff/1/chrome/browser/chromeos/poli...
File chrome/browser/chromeos/policy/proto/chrome_device_policy.proto (right):

https://codereview.chromium.org/293033012/diff/1/chrome/browser/chromeos/poli...
chrome/browser/chromeos/policy/proto/chrome_device_policy.proto:571: // this
flag to false, the system will refuse to boot and show and error
and show "an" error

https://codereview.chromium.org/293033012/diff/1/chrome/browser/chromeos/poli...
chrome/browser/chromeos/policy/proto/chrome_device_policy.proto:571: // this
flag to false, the system will refuse to boot and show and error
I think you meant "if the flag is set to true" :-)

https://codereview.chromium.org/293033012/diff/1/components/policy/resources/...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/293033012/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.json:4318: If this policy is set to
True, <ph name="PRODUCT_OS_NAME">$2<ex>Google Chrome OS</ex></ph> will prevent
the device from booting into developer mode. The system will refuse to boot and
show an error screen when the developer switch is turned no.
turned "on"

[Ilya Sherman, 2014-05-22 15:30:11]

histograms LGTM

[Mattias Nissler (ping if slow), 2014-05-23 06:51:25]

Thanks for the reviews. Julian, any further input?

https://codereview.chromium.org/293033012/diff/1/chrome/browser/chromeos/poli...
File chrome/browser/chromeos/policy/proto/chrome_device_policy.proto (right):

https://codereview.chromium.org/293033012/diff/1/chrome/browser/chromeos/poli...
chrome/browser/chromeos/policy/proto/chrome_device_policy.proto:571: // this
flag to false, the system will refuse to boot and show and error
On 2014/05/22 15:04:07, Joao da Silva wrote:
> and show "an" error

Done.

https://codereview.chromium.org/293033012/diff/1/chrome/browser/chromeos/poli...
chrome/browser/chromeos/policy/proto/chrome_device_policy.proto:571: // this
flag to false, the system will refuse to boot and show and error
On 2014/05/22 15:04:07, Joao da Silva wrote:
> I think you meant "if the flag is set to true" :-)

Done.

https://codereview.chromium.org/293033012/diff/1/components/policy/resources/...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/293033012/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.json:4318: If this policy is set to
True, <ph name="PRODUCT_OS_NAME">$2<ex>Google Chrome OS</ex></ph> will prevent
the device from booting into developer mode. The system will refuse to boot and
show an error screen when the developer switch is turned no.
On 2014/05/22 15:04:07, Joao da Silva wrote:
> turned "on"

Done.

[pastarmovj, 2014-05-23 09:30:50]

lgtm

[Mattias Nissler (ping if slow), 2014-05-23 10:04:14]

The CQ bit was checked by mnissler@chromium.org

[commit-bot: I haz the power, 2014-05-23 10:05:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mnissler@chromium.org/293033012/20001

[commit-bot: I haz the power, 2014-05-23 12:09:28]

Change committed as 272502