Media Galleries: Make DeviceMediaAsyncFileUtil filter directory contents.

chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media_galleries/fileapi/device_media_async_file_util.h"
 
 #include "base/callback.h"
 #include "base/file_util.h"
 #include "base/single_thread_task_runner.h"
 #include "base/task_runner_util.h"
@@ skipping 28 matching lines @@
 
 // Called when GetFileInfo method call failed to get the details of file
 // specified by the requested url. |callback| is invoked to notify the
 // caller about the file |error|.
 void OnGetFileInfoError(const AsyncFileUtil::GetFileInfoCallback& callback,
                         base::File::Error error) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
   callback.Run(error, base::File::Info());
 }
 
+// Called after OnDidGetFileInfo finishes media check.
+// |callback| is invoked to complete the GetFileInfo request.
+void OnDidCheckMediaForGetFileInfo(
+    const AsyncFileUtil::GetFileInfoCallback& callback,
+    const base::File::Info& file_info,
+    bool is_valid_file) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+  if (!is_valid_file) {
+    OnGetFileInfoError(callback, base::File::FILE_ERROR_NOT_FOUND);
+    return;
+  }
+  callback.Run(base::File::FILE_OK, file_info);
+}
+
+// Called after OnDidReadDirectory finishes media check.
+// |callback| is invoked to complete the ReadDirectory request.
+void OnDidCheckMediaForReadDirectory(
+    const AsyncFileUtil::ReadDirectoryCallback& callback,
+    bool has_more,
+    const AsyncFileUtil::EntryList& file_list) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+  callback.Run(base::File::FILE_OK, file_list, has_more);
+}
+
 // Called when ReadDirectory method call failed to enumerate the directory
 // objects. |callback| is invoked to notify the caller about the |error|
 // that occured while reading the directory objects.
 void OnReadDirectoryError(const AsyncFileUtil::ReadDirectoryCallback& callback,
                           base::File::Error error) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
   callback.Run(error, AsyncFileUtil::EntryList(), false /*no more*/);
 }
 
 // Called on a blocking pool thread to create a snapshot file to hold the
@@ skipping 98 matching lines @@
       snapshot_file_path,
       base::Bind(&OnDidCreateSnapshotFile,
                  callback,
                  make_scoped_refptr(context->task_runner()),
                  validate_media_files),
       base::Bind(&OnCreateSnapshotFileError, callback));
 }
 
 }  // namespace
 
+class DeviceMediaAsyncFileUtil::MediaPathFilterWrapper
+    : public base::RefCountedThreadSafe<MediaPathFilterWrapper> {

[vandebo (ex-Chrome), 2014/05/22 17:17:42]

DeviceMediaAsyncFileUtil already has a weak factory, there's no need to
introduce this thread safe ref counted object.

[Lei Zhang, 2014/05/22 18:11:12]

That WeakPtr factor is used on the IO thread. You can't reuse it on the media
task runner.

+ public:
+  MediaPathFilterWrapper();
+
+  // Check if entries in |file_list| look like media files.
+  // Append the ones that look like media files to |results|.
+  // Should run on a media task runner.
+  AsyncFileUtil::EntryList FilterMediaEntries(
+      const AsyncFileUtil::EntryList& file_list);
+
+  // Check if |path| looks like a media file.
+  bool CheckFilePath(const base::FilePath& path);
+
+ private:
+  friend class base::RefCountedThreadSafe<MediaPathFilterWrapper>;
+
+  virtual ~MediaPathFilterWrapper();
+
+  scoped_ptr<MediaPathFilter> media_path_filter_;
+
+  DISALLOW_COPY_AND_ASSIGN(MediaPathFilterWrapper);
+};
+
+DeviceMediaAsyncFileUtil::MediaPathFilterWrapper::MediaPathFilterWrapper()
+    : media_path_filter_(new MediaPathFilter) {
+}
+
+DeviceMediaAsyncFileUtil::MediaPathFilterWrapper::~MediaPathFilterWrapper() {
+}
+
+AsyncFileUtil::EntryList
+DeviceMediaAsyncFileUtil::MediaPathFilterWrapper::FilterMediaEntries(
+    const AsyncFileUtil::EntryList& file_list) {
+  AsyncFileUtil::EntryList results;
+  for (size_t i = 0; i < file_list.size(); ++i) {
+    const fileapi::DirectoryEntry& entry = file_list[i];
+    if (entry.is_directory || CheckFilePath(base::FilePath(entry.name))) {
+      results.push_back(entry);
+    }
+  }
+  return results;
+}
+
+bool DeviceMediaAsyncFileUtil::MediaPathFilterWrapper::CheckFilePath(
+    const base::FilePath& path) {
+  return media_path_filter_->Match(path);
+}
+
 DeviceMediaAsyncFileUtil::~DeviceMediaAsyncFileUtil() {
 }
 
 // static
 scoped_ptr<DeviceMediaAsyncFileUtil> DeviceMediaAsyncFileUtil::Create(
     const base::FilePath& profile_path,
     MediaFileValidationType validation_type) {
   DCHECK(!profile_path.empty());
   return make_scoped_ptr(
       new DeviceMediaAsyncFileUtil(profile_path, validation_type));
@@ skipping 57 matching lines @@
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
   MTPDeviceAsyncDelegate* delegate = GetMTPDeviceDelegate(url);
   if (!delegate) {
     OnGetFileInfoError(callback, base::File::FILE_ERROR_NOT_FOUND);
     return;
   }
   delegate->GetFileInfo(
       url.path(),
       base::Bind(&DeviceMediaAsyncFileUtil::OnDidGetFileInfo,
                  weak_ptr_factory_.GetWeakPtr(),
+                 base::Passed(&context),
+                 url.path(),
                  callback),
       base::Bind(&OnGetFileInfoError, callback));
 }
 
 void DeviceMediaAsyncFileUtil::ReadDirectory(
     scoped_ptr<FileSystemOperationContext> context,
     const FileSystemURL& url,
     const ReadDirectoryCallback& callback) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
   MTPDeviceAsyncDelegate* delegate = GetMTPDeviceDelegate(url);
   if (!delegate) {
     OnReadDirectoryError(callback, base::File::FILE_ERROR_NOT_FOUND);
     return;
   }
   delegate->ReadDirectory(
       url.path(),
       base::Bind(&DeviceMediaAsyncFileUtil::OnDidReadDirectory,
                  weak_ptr_factory_.GetWeakPtr(),
+                 base::Passed(&context),
                  callback),
       base::Bind(&OnReadDirectoryError, callback));
 }
 
 void DeviceMediaAsyncFileUtil::Touch(
     scoped_ptr<FileSystemOperationContext> context,
     const FileSystemURL& url,
     const base::Time& last_access_time,
     const base::Time& last_modified_time,
     const StatusCallback& callback) {
@@ skipping 111 matching lines @@
                                   url,
                                   offset,
                                   expected_modification_time,
                                   validate_media_files())));
 }
 
 DeviceMediaAsyncFileUtil::DeviceMediaAsyncFileUtil(
     const base::FilePath& profile_path,
     MediaFileValidationType validation_type)
     : profile_path_(profile_path),
-      validation_type_(validation_type),
       weak_ptr_factory_(this) {
+  if (validation_type == APPLY_MEDIA_FILE_VALIDATION) {
+    media_path_filter_wrapper_ = new MediaPathFilterWrapper;
+  }
 }
 
 void DeviceMediaAsyncFileUtil::OnDidGetFileInfo(
-    const GetFileInfoCallback& callback,
+    scoped_ptr<FileSystemOperationContext> context,
+    const base::FilePath& path,
+    const AsyncFileUtil::GetFileInfoCallback& callback,
     const base::File::Info& file_info) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
-  callback.Run(base::File::FILE_OK, file_info);
+  if (file_info.is_directory || !validate_media_files()) {
+    callback.Run(base::File::FILE_OK, file_info);

[vandebo (ex-Chrome), 2014/05/22 17:17:42]

nit: call OnDidCheckMediaForGetFileInfo() ?

[Lei Zhang, 2014/05/22 20:38:15]

Done.

+    return;
+  }
+
+  scoped_refptr<base::SequencedTaskRunner> task_runner = context->task_runner();

[vandebo (ex-Chrome), 2014/05/22 17:17:42]

inline?

[Lei Zhang, 2014/05/22 18:11:12]

We have to take a reference or else |task_runner| can go away at the wrong time.
Same pattern is used all over.

[vandebo (ex-Chrome), 2014/05/22 18:22:24]

Doesn't PostTask take a ref if it's a refcounted type?

[Lei Zhang, 2014/05/22 19:51:16]

PostTaskAndReplyWithResult() takes a TaskRunner*, but actually I think you are
right. The reason we had to do it in other places is because we Bind() with
base::Passed(&context).

[Lei Zhang, 2014/05/22 20:38:15]

Done.

+  base::PostTaskAndReplyWithResult(
+      task_runner,
+      FROM_HERE,
+      base::Bind(&MediaPathFilterWrapper::CheckFilePath,
+                 media_path_filter_wrapper_,
+                 path),
+      base::Bind(&OnDidCheckMediaForGetFileInfo, callback, file_info));
 }
 
 void DeviceMediaAsyncFileUtil::OnDidReadDirectory(
-    const ReadDirectoryCallback& callback,
-    const EntryList& file_list,
+    scoped_ptr<fileapi::FileSystemOperationContext> context,
+    const AsyncFileUtil::ReadDirectoryCallback& callback,
+    const AsyncFileUtil::EntryList& file_list,
     bool has_more) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
-  callback.Run(base::File::FILE_OK, file_list, has_more);
+  if (!validate_media_files()) {
+    OnDidCheckMediaForReadDirectory(callback, has_more, file_list);
+    return;
+  }
+
+  scoped_refptr<base::SequencedTaskRunner> task_runner = context->task_runner();

[vandebo (ex-Chrome), 2014/05/22 17:17:42]

ditto?

[Lei Zhang, 2014/05/22 20:38:15]

Done.

+  base::PostTaskAndReplyWithResult(
+      task_runner,
+      FROM_HERE,
+      base::Bind(&MediaPathFilterWrapper::FilterMediaEntries,
+                 media_path_filter_wrapper_,
+                 file_list),
+      base::Bind(&OnDidCheckMediaForReadDirectory, callback, has_more));
 }
 
 bool DeviceMediaAsyncFileUtil::validate_media_files() const {
-  return validation_type_ == APPLY_MEDIA_FILE_VALIDATION;
+  return media_path_filter_wrapper_.get() != NULL;
 }