Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 293033005: Mojo: Mojom: Remove default values for structs and arrays. (Closed)

Created:
6 years, 7 months ago by viettrungluu
Modified:
6 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Mojom: Remove default values for structs and arrays. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272001

Patch Set 1 #

Patch Set 2 : fix js tests #

Patch Set 3 : moar generator bugs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -104 lines) Patch
M mojo/apps/js/bindings/sample_service_unittests.js View 1 2 1 chunk +30 lines, -25 lines 0 comments Download
M mojo/bindings/js/codec_unittests.js View 1 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/sample_service_unittest.cc View 1 2 1 chunk +26 lines, -32 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_import2.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_service.mojom View 1 2 1 chunk +32 lines, -11 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/parser.py View 2 chunks +0 lines, -35 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
viettrungluu
6 years, 7 months ago (2014-05-20 23:48:24 UTC) #1
darin (slow to review)
LGTM
6 years, 7 months ago (2014-05-21 04:03:28 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 7 months ago (2014-05-21 17:58:10 UTC) #3
viettrungluu
The CQ bit was unchecked by viettrungluu@chromium.org
6 years, 7 months ago (2014-05-21 19:26:20 UTC) #4
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 7 months ago (2014-05-21 19:26:27 UTC) #5
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 7 months ago (2014-05-21 19:38:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/293033005/40001
6 years, 7 months ago (2014-05-21 19:58:29 UTC) #7
viettrungluu
6 years, 7 months ago (2014-05-21 22:53:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r272001 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698