Make Display's rotation and WebScreenInfo rotation work together on Aura.

Make Display's rotation and WebScreenInfo rotation worke together on Aura.

BUG=162827
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277759

[mlamouri (slow - plz ping), 2014-05-23 09:44:59]

Nico, friendly to make sure you didn't forget about this review :)

[mlamouri (slow - plz ping), 2014-06-16 18:46:22]

jam@, I've been pretty unsuccessful with getting this reviewed so far, could you
have a look maybe?

[jam, 2014-06-16 20:00:36]

someone more familiar with aura should look. redirecting to sky.

[sky, 2014-06-16 20:18:42]

https://codereview.chromium.org/293033004/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

https://codereview.chromium.org/293033004/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_aura.cc:304: // The
Display rotation and the WebScreenInfo orientation are not the same
Are you saying the webkit rotation is relative to the physical rotation? If you
need to rotate an additional 180 (which is what you're doing), why isn't 180
special cased?

[mlamouri (slow - plz ping), 2014-06-16 20:23:27]

https://codereview.chromium.org/293033004/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

https://codereview.chromium.org/293033004/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_aura.cc:304: // The
Display rotation and the WebScreenInfo orientation are not the same
On 2014/06/16 20:18:42, sky wrote:
> Are you saying the webkit rotation is relative to the physical rotation? If
you
> need to rotate an additional 180 (which is what you're doing), why isn't 180
> special cased?

The value is Blink is the rotation of the rendering relative to the display
(screen). When the value is 0, the rendering isn't rotated to be displayed
correctly. When the display is rotated of 180 degrees, we need to rotate the
screen of 180 degrees to see the content correctly. However, when the display is
rotated of 90 degrees, we need to rotate it of -90 degrees to see the content
correctly. We don't want negative values so it becomes 270. For 270, we need to
rotate of -270, or 90.

[sky, 2014-06-16 20:53:03]

LGTM

https://codereview.chromium.org/293033004/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

https://codereview.chromium.org/293033004/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_aura.cc:304: // The
Display rotation and the WebScreenInfo orientation are not the same
On 2014/06/16 20:23:27, Mounir Lamouri wrote:
> On 2014/06/16 20:18:42, sky wrote:
> > Are you saying the webkit rotation is relative to the physical rotation? If
> you
> > need to rotate an additional 180 (which is what you're doing), why isn't 180
> > special cased?
> 
> The value is Blink is the rotation of the rendering relative to the display
> (screen). When the value is 0, the rendering isn't rotated to be displayed
> correctly. When the display is rotated of 180 degrees, we need to rotate the
> screen of 180 degrees to see the content correctly. However, when the display
is
> rotated of 90 degrees, we need to rotate it of -90 degrees to see the content
> correctly. We don't want negative values so it becomes 270. For 270, we need
to
> rotate of -270, or 90.

I got it. Can you clarify here that webscreeninfo is relative to physical. That
would help my understanding of it.

[mlamouri (slow - plz ping), 2014-06-16 21:07:30]

https://codereview.chromium.org/293033004/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

https://codereview.chromium.org/293033004/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_aura.cc:304: // The
Display rotation and the WebScreenInfo orientation are not the same
On 2014/06/16 20:53:02, sky wrote:
> On 2014/06/16 20:23:27, Mounir Lamouri wrote:
> > On 2014/06/16 20:18:42, sky wrote:
> > > Are you saying the webkit rotation is relative to the physical rotation?
If
> > you
> > > need to rotate an additional 180 (which is what you're doing), why isn't
180
> > > special cased?
> > 
> > The value is Blink is the rotation of the rendering relative to the display
> > (screen). When the value is 0, the rendering isn't rotated to be displayed
> > correctly. When the display is rotated of 180 degrees, we need to rotate the
> > screen of 180 degrees to see the content correctly. However, when the
display
> is
> > rotated of 90 degrees, we need to rotate it of -90 degrees to see the
content
> > correctly. We don't want negative values so it becomes 270. For 270, we need
> to
> > rotate of -270, or 90.
> 
> I got it. Can you clarify here that webscreeninfo is relative to physical.
That
> would help my understanding of it.

By the way, WebScreenInfo behaves like that because it is the only real solution
for mobile devices: the physical rotation is different from the content's
rotation. Do you know if Aura is consistent with that kind of stuff? For
example, with Windows 8?

[sky, 2014-06-17 03:02:45]

I'm not sure if support rotation like that on win8. Ananta and/or cpu may
know.


On Mon, Jun 16, 2014 at 2:07 PM, <mlamouri@chromium.org> wrote:

>
> https://codereview.chromium.org/293033004/diff/1/content/
> browser/renderer_host/render_widget_host_view_aura.cc
> File content/browser/renderer_host/render_widget_host_view_aura.cc
> (right):
>
> https://codereview.chromium.org/293033004/diff/1/content/
> browser/renderer_host/render_widget_host_view_aura.cc#newcode304
> content/browser/renderer_host/render_widget_host_view_aura.cc:304: //
> The Display rotation and the WebScreenInfo orientation are not the same
> On 2014/06/16 20:53:02, sky wrote:
>
>> On 2014/06/16 20:23:27, Mounir Lamouri wrote:
>> > On 2014/06/16 20:18:42, sky wrote:
>> > > Are you saying the webkit rotation is relative to the physical
>>
> rotation? If
>
>> > you
>> > > need to rotate an additional 180 (which is what you're doing), why
>>
> isn't 180
>
>> > > special cased?
>> >
>> > The value is Blink is the rotation of the rendering relative to the
>>
> display
>
>> > (screen). When the value is 0, the rendering isn't rotated to be
>>
> displayed
>
>> > correctly. When the display is rotated of 180 degrees, we need to
>>
> rotate the
>
>> > screen of 180 degrees to see the content correctly. However, when
>>
> the display
>
>> is
>> > rotated of 90 degrees, we need to rotate it of -90 degrees to see
>>
> the content
>
>> > correctly. We don't want negative values so it becomes 270. For 270,
>>
> we need
>
>> to
>> > rotate of -270, or 90.
>>
>
>  I got it. Can you clarify here that webscreeninfo is relative to
>>
> physical. That
>
>> would help my understanding of it.
>>
>
> By the way, WebScreenInfo behaves like that because it is the only real
> solution for mobile devices: the physical rotation is different from the
> content's rotation. Do you know if Aura is consistent with that kind of
> stuff? For example, with Windows 8?
>
> https://codereview.chromium.org/293033004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mlamouri (slow - plz ping), 2014-06-17 09:55:41]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-06-17 09:57:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlamouri@chromium.org/293033004/20001

[commit-bot: I haz the power, 2014-06-17 13:50:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 13:50:30]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[mlamouri (slow - plz ping), 2014-06-17 13:51:28]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-06-17 13:51:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlamouri@chromium.org/293033004/20001

[commit-bot: I haz the power, 2014-06-17 14:52:50]

Change committed as 277759