Show client placeholders for Server LoFi images.

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 1060 matching lines @@
      arraysize(kOmniboxUIVerticalMargin6px), nullptr},
     {"8px vertical margin", kOmniboxUIVerticalMargin8px,
      arraysize(kOmniboxUIVerticalMargin8px), nullptr},
     {"10px vertical margin", kOmniboxUIVerticalMargin10px,
      arraysize(kOmniboxUIVerticalMargin10px), nullptr},
     {"12px vertical margin", kOmniboxUIVerticalMargin12px,
      arraysize(kOmniboxUIVerticalMargin12px), nullptr},
     {"14px vertical margin", kOmniboxUIVerticalMargin14px,
      arraysize(kOmniboxUIVerticalMargin14px), nullptr}};
 
+const FeatureEntry::FeatureParam kClientPlaceholdersForServerLoFiEnabled[] = {
+    {"replace_server_placeholders", "true"}};
+
+const FeatureEntry::FeatureVariation
+    kClientPlaceholdersForServerLoFiFeatureVariations[] = {
+        {"(replace Server LoFi placeholders)",

[megjablon, 2017/06/30 18:19:21]

nit: I'd use Lo-Fi since that's what we use in the other about_flags
descriptions.

[sclittle, 2017/06/30 21:21:06]

Done.

+         kClientPlaceholdersForServerLoFiEnabled,
+         arraysize(kClientPlaceholdersForServerLoFiEnabled), nullptr}};
+
 // RECORDING USER METRICS FOR FLAGS:
 // -----------------------------------------------------------------------------
 // The first line of the entry is the internal name.
 //
 // To add a new entry, add to the end of kFeatureEntries. There are two
 // distinct types of entries:
 // . SINGLE_VALUE: entry is either on or off. Use the SINGLE_VALUE_TYPE
 //   macro for this type supplying the command line to the macro.
 // . MULTI_VALUE: a list of choices, the first of which should correspond to a
 //   deactivated state for this lab (i.e. no command line option).  To specify
@@ skipping 884 matching lines @@
          "DataReductionProxyMainMenu")},
     {"enable-data-reduction-proxy-site-breakdown",
      flag_descriptions::kEnableDataReductionProxySiteBreakdownName,
      flag_descriptions::kEnableDataReductionProxySiteBreakdownDescription,
      kOsAndroid,
      FEATURE_VALUE_TYPE(
          data_reduction_proxy::features::kDataReductionSiteBreakdown)},
     {"enable-offline-previews", flag_descriptions::kEnableOfflinePreviewsName,
      flag_descriptions::kEnableOfflinePreviewsDescription, kOsAndroid,
      FEATURE_VALUE_TYPE(previews::features::kOfflinePreviews)},
+#endif  // OS_ANDROID
     {"enable-client-lo-fi", flag_descriptions::kEnableClientLoFiName,
-     flag_descriptions::kEnableClientLoFiDescription, kOsAndroid,
-     FEATURE_VALUE_TYPE(previews::features::kClientLoFi)},
-#endif  // OS_ANDROID
+     flag_descriptions::kEnableClientLoFiDescription, kOsAll,
+     FEATURE_WITH_PARAMS_VALUE_TYPE(
+         previews::features::kClientLoFi,
+         kClientPlaceholdersForServerLoFiFeatureVariations,
+         "PreviewsClientLoFi")},
     {"allow-insecure-localhost", flag_descriptions::kAllowInsecureLocalhostName,
      flag_descriptions::kAllowInsecureLocalhostDescription, kOsAll,
      SINGLE_VALUE_TYPE(switches::kAllowInsecureLocalhost)},
 #if !defined(OS_ANDROID)
     {"enable-app-banners", flag_descriptions::kAppBannersName,
      flag_descriptions::kAppBannersDescription, kOsDesktop,
      FEATURE_VALUE_TYPE(features::kAppBanners)},
 #endif  // !OS_ANDROID
     {"enable-experimental-app-banners",
      flag_descriptions::kExperimentalAppBannersName,
@@ skipping 1330 matching lines @@
 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
 
 const FeatureEntry* GetFeatureEntries(size_t* count) {
   *count = arraysize(kFeatureEntries);
   return kFeatureEntries;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags