Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

Issue 29303007: android: Enable -Wunused-const-variable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/autofill/autofill_popup_controller_impl.h" 5 #include "chrome/browser/ui/autofill/autofill_popup_controller_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 12 matching lines...) Expand all
23 23
24 using base::WeakPtr; 24 using base::WeakPtr;
25 using WebKit::WebAutofillClient; 25 using WebKit::WebAutofillClient;
26 26
27 namespace autofill { 27 namespace autofill {
28 namespace { 28 namespace {
29 29
30 // Used to indicate that no line is currently selected by the user. 30 // Used to indicate that no line is currently selected by the user.
31 const int kNoSelection = -1; 31 const int kNoSelection = -1;
32 32
33 // Size difference between name and subtext in pixels.
34 const int kLabelFontSizeDelta = -2;
35
36 // The vertical height of each row in pixels. 33 // The vertical height of each row in pixels.
37 const size_t kRowHeight = 24; 34 const size_t kRowHeight = 24;
38 35
39 // The vertical height of a separator in pixels. 36 // The vertical height of a separator in pixels.
40 const size_t kSeparatorHeight = 1; 37 const size_t kSeparatorHeight = 1;
41 38
42 #if !defined(OS_ANDROID) 39 #if !defined(OS_ANDROID)
40 // Size difference between name and subtext in pixels.
41 const int kLabelFontSizeDelta = -2;
42
43 const size_t kNamePadding = AutofillPopupView::kNamePadding; 43 const size_t kNamePadding = AutofillPopupView::kNamePadding;
44 const size_t kIconPadding = AutofillPopupView::kIconPadding; 44 const size_t kIconPadding = AutofillPopupView::kIconPadding;
45 const size_t kEndPadding = AutofillPopupView::kEndPadding; 45 const size_t kEndPadding = AutofillPopupView::kEndPadding;
46 const size_t kAutofillIconWidth = AutofillPopupView::kAutofillIconWidth; 46 const size_t kAutofillIconWidth = AutofillPopupView::kAutofillIconWidth;
47 #endif 47 #endif
48 48
49 struct DataResource { 49 struct DataResource {
50 const char* name; 50 const char* name;
51 int id; 51 int id;
52 }; 52 };
(...skipping 677 matching lines...) Expand 10 before | Expand all | Expand 10 after
730 // The popup can appear below the field. 730 // The popup can appear below the field.
731 return std::make_pair(bottom_growth_start, popup_required_height); 731 return std::make_pair(bottom_growth_start, popup_required_height);
732 } else { 732 } else {
733 // The popup must appear above the field. 733 // The popup must appear above the field.
734 return std::make_pair(top_growth_end - popup_required_height, 734 return std::make_pair(top_growth_end - popup_required_height,
735 popup_required_height); 735 popup_required_height);
736 } 736 }
737 } 737 }
738 738
739 } // namespace autofill 739 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698