chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java - Issue 29303004: Make WindowAndroid constructor takes context as param.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

Issue 29303004: Make WindowAndroid constructor takes context as param. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java ('k') | chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java » ('j') | ui/android/java/src/org/chromium/ui/WindowAndroid.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

index 76af25cea2b76103fba3b12ded07952c515599bb..0d005c582516e6724dde67687ca62efe5c224160 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

@@ -4,10 +4,7 @@

package org.chromium.chrome.browser.input;

-import android.test.suitebuilder.annotation.LargeTest;

import org.chromium.base.test.util.DisabledTest;

-import org.chromium.base.test.util.Feature;

import org.chromium.base.test.util.UrlUtils;

import org.chromium.content.browser.ContentView;

import org.chromium.content.browser.input.SelectPopupDialog;

@@ -18,10 +15,9 @@ import org.chromium.content.browser.test.util.TestCallbackHelperContainer;

import org.chromium.content.browser.test.util.UiUtils;

import org.chromium.chrome.browser.ContentViewUtil;

import org.chromium.chrome.testshell.ChromiumTestShellTestBase;

+import org.chromium.ui.ActivityWindowAndroid;

import org.chromium.ui.WindowAndroid;

-import java.util.concurrent.TimeUnit;

public class SelectPopupOtherContentViewTest extends ChromiumTestShellTestBase {

private static final int WAIT_TIMEOUT_SECONDS = 2;

private static final String SELECT_URL = UrlUtils.encodeHtmlDataUri(

@@ -77,7 +73,7 @@ public class SelectPopupOtherContentViewTest extends ChromiumTestShellTestBase {

@Override

public void run() {

int nativeWebContents = ContentViewUtil.createNativeWebContents(false);

- WindowAndroid windowAndroid = new WindowAndroid(getActivity());

+ WindowAndroid windowAndroid = new ActivityWindowAndroid(getActivity());

ContentView contentView = ContentView.newInstance(

getActivity(), nativeWebContents, windowAndroid);

contentView.destroy();