Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: pkg/compiler/lib/src/elements/elements.dart

Issue 2930293002: Parameterize and move JumpTarget/LabelDefition to elements/jumps.dart (Closed)
Patch Set: Fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/elements/jumps.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/elements/elements.dart
diff --git a/pkg/compiler/lib/src/elements/elements.dart b/pkg/compiler/lib/src/elements/elements.dart
index 083b2659ba32fd333f889e4c0bc1607c44c951f8..c0c3834d3cae22d5d6ed75f0a5092a8cef3c656e 100644
--- a/pkg/compiler/lib/src/elements/elements.dart
+++ b/pkg/compiler/lib/src/elements/elements.dart
@@ -21,6 +21,7 @@ import '../util/util.dart';
import '../world.dart' show ClosedWorld;
import 'entities.dart';
import 'entity_utils.dart' as utils;
+import 'jumps.dart';
import 'names.dart';
import 'resolution_types.dart';
import 'types.dart';
@@ -1608,39 +1609,6 @@ abstract class EnumConstantElement extends FieldElement {
int get index;
}
-/// The label entity defined by a labeled statement.
-abstract class LabelDefinition extends Entity {
- Label get label;
- String get labelName;
- JumpTarget get target;
-
- bool get isTarget;
- bool get isBreakTarget;
- bool get isContinueTarget;
-
- void setBreakTarget();
- void setContinueTarget();
-}
-
-/// A jump target is the reference point of a statement or switch-case,
-/// either by label or as the default target of a break or continue.
-abstract class JumpTarget extends Local {
- Node get statement;
- int get nestingLevel;
- List<LabelDefinition> get labels;
-
- bool get isTarget;
- bool get isBreakTarget;
- bool get isContinueTarget;
- bool get isSwitch;
-
- // TODO(kasperl): Try to get rid of these.
- void set isBreakTarget(bool value);
- void set isContinueTarget(bool value);
-
- LabelDefinition addLabel(Label label, String labelName);
-}
-
/// The [Element] for a type variable declaration on a generic class or typedef.
abstract class TypeVariableElement extends Element
implements AstElement, TypedElement, TypeVariableEntity {
« no previous file with comments | « no previous file | pkg/compiler/lib/src/elements/jumps.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698