Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2930293002: Parameterize and move JumpTarget/LabelDefition to elements/jumps.dart (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, Emily Fortuna
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Parameterize and move JumpTarget/LabelDefition to elements/jumps.dart R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/6a6a3306233b968b5b1abff2ab0a22642f570a2c

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -51 lines) Patch
M pkg/compiler/lib/src/elements/elements.dart View 2 chunks +1 line, -33 lines 0 comments Download
A pkg/compiler/lib/src/elements/jumps.dart View 1 chunk +40 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 4 chunks +7 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/label_scope.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/tree_elements.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/graph_builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/jump_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/loop_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Johnni Winther
3 years, 6 months ago (2017-06-12 09:33:19 UTC) #2
Emily Fortuna
lgtm
3 years, 6 months ago (2017-06-12 17:03:33 UTC) #4
Johnni Winther
3 years, 6 months ago (2017-06-14 10:27:46 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
6a6a3306233b968b5b1abff2ab0a22642f570a2c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698