Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: ui/accessibility/ax_tree_unittest.cc

Issue 2930273002: Use ContainsValue() instead of std::find() in ui/accessibility, ui/gl and ui/ozone (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/accessibility/ax_tree_unittest.cc
diff --git a/ui/accessibility/ax_tree_unittest.cc b/ui/accessibility/ax_tree_unittest.cc
index 3618332c4d4d924a7dd1300e9cf949303e471b9c..6f2b1e51b3f75f4d4d4eb7b6a0daf497a8a0046c 100644
--- a/ui/accessibility/ax_tree_unittest.cc
+++ b/ui/accessibility/ax_tree_unittest.cc
@@ -9,6 +9,7 @@
#include <memory>
+#include "base/stl_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -514,11 +515,9 @@ TEST(AXTreeTest, ReparentingDoesNotTriggerNodeCreated) {
fake_delegate.subtree_reparented_finished_ids();
std::vector<int> node_reparented =
fake_delegate.node_reparented_finished_ids();
- ASSERT_EQ(std::find(created.begin(), created.end(), 3), created.end());
- ASSERT_NE(std::find(subtree_reparented.begin(), subtree_reparented.end(), 3),
- subtree_reparented.end());
- ASSERT_EQ(std::find(node_reparented.begin(), node_reparented.end(), 3),
- node_reparented.end());
+ ASSERT(!base::ContainsValue(created, 3));
+ ASSERT(base::ContainsValue(subtree_reparented, 3));
+ ASSERT(!base::ContainsValue(node_reparented, 3));
sadrul 2017/06/14 02:43:01 Use ASSERT_FALSE/ASSERT_TRUE in the above.
Tripta 2017/06/14 05:46:17 Done.
}
TEST(AXTreeTest, TreeDelegateIsNotCalledForReparenting) {

Powered by Google App Engine
This is Rietveld 408576698