Bring back initPolymer, allow boot.js only if using "polymer_experimental.html".

pkg/polymer/lib/src/build/linter.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Logic to validate that developers are correctly using Polymer constructs.
 /// This is mainly used to produce warnings for feedback in the editor.
 library polymer.src.build.linter;
 
 import 'dart:async';
 
@@ skipping 58 matching lines @@
 
   Future<List<AssetId>> _getImportedIds(
       Document document, AssetId sourceId, Transform transform) {
     var importIds = [];
     var logger = transform.logger;
     for (var tag in document.querySelectorAll('link')) {
       if (tag.attributes['rel'] != 'import') continue;
       var href = tag.attributes['href'];
       var span = tag.sourceSpan;
       var id = uriToAssetId(sourceId, href, logger, span);
-      if (id == null ||
-          (id.package == 'polymer' && id.path == 'lib/init.html')) continue;
+      if (id == null) continue;
       importIds.add(assetExists(id, transform).then((exists) {
         if (exists) return id;
         if (sourceId == transform.primaryInput.id) {
           logger.error('couldn\'t find imported asset "${id.path}" in package '
               '"${id.package}".', span: span);
         }
       }));
     }
     return Future.wait(importIds);
   }
@@ skipping 43 matching lines @@
   _ElementSummary(this.tagName, this.extendsTag, this.span);
 
   String toString() => "($tagName <: $extendsTag)";
 }
 
 class _LinterVisitor extends TreeVisitor {
   TransformLogger _logger;
   bool _inPolymerElement = false;
   bool _dartTagSeen = false;
   bool _polymerHtmlSeen = false;
+  bool _polymerExperimentalHtmlSeen = false;
   bool _isEntrypoint;
   Map<String, _ElementSummary> _elements;
 
   _LinterVisitor(this._logger, this._elements, this._isEntrypoint) {
     // We normalize the map, so each element has a direct reference to any
     // element it extends from.
     for (var tag in _elements.values) {
       var extendsTag = tag.extendsTag;
       if (extendsTag == null) continue;
       tag.extendsType = _elements[extendsTag];
     }
   }
 
   void visitElement(Element node) {
     switch (node.localName) {
       case 'link': _validateLinkElement(node); break;
       case 'element': _validateElementElement(node); break;
       case 'polymer-element': _validatePolymerElement(node); break;
       case 'script': _validateScriptElement(node); break;
       default:
          _validateNormalElement(node);
          super.visitElement(node);
          break;
     }
   }
 
   void run(Document doc) {
     visit(doc);
 
-    if (_isEntrypoint && !_polymerHtmlSeen) {
+    if (_isEntrypoint && !_polymerHtmlSeen && !_polymerExperimentalHtmlSeen) {
       _logger.warning(USE_POLYMER_HTML, span: doc.body.sourceSpan);
     }
+
+    if (_isEntrypoint && !_dartTagSeen && !_polymerExperimentalHtmlSeen) {
+      _logger.warning(USE_INIT_DART, span: doc.body.sourceSpan);
+    }
   }
 
   /// Produce warnings for invalid link-rel tags.
   void _validateLinkElement(Element node) {
     var rel = node.attributes['rel'];
     if (rel != 'import' && rel != 'stylesheet') return;
 
     if (rel == 'import' && _dartTagSeen) {
-      _logger.warning(
-          "Move HTML imports above your Dart script tag.",
+      _logger.warning("Move HTML imports above your Dart script tag.",
           span: node.sourceSpan);
     }
 
     var href = node.attributes['href'];
     if (href == null || href == '') {
       _logger.warning('link rel="$rel" missing href.', span: node.sourceSpan);
       return;
     }
 
     if (href == 'packages/polymer/polymer.html') {
       _polymerHtmlSeen = true;
+    } else if (href == POLYMER_EXPERIMENTAL_HTML) {
+      _polymerExperimentalHtmlSeen = true;
     }
     // TODO(sigmund): warn also if href can't be resolved.
   }
 
   /// Produce warnings if using `<element>` instead of `<polymer-element>`.
   void _validateElementElement(Element node) {
     _logger.warning('<element> elements are not supported, use'
         ' <polymer-element> instead', span: node.sourceSpan);
   }
 
@@ skipping 37 matching lines @@
     }
 
     var oldValue = _inPolymerElement;
     _inPolymerElement = true;
     super.visitElement(node);
     _inPolymerElement = oldValue;
   }
 
   /// Checks for multiple Dart script tags in the same page, which is invalid.
   void _validateScriptElement(Element node) {
+    var scriptType = node.attributes['type'];
+    var isDart = scriptType == 'application/dart';
     var src = node.attributes['src'];
+
+    if (isDart) {
+      if (_dartTagSeen) _logger.warning(ONLY_ONE_TAG, span: node.sourceSpan);
+      if (_isEntrypoint && _polymerExperimentalHtmlSeen) {
+        _logger.warning(NO_DART_SCRIPT_AND_EXPERIMENTAL, span: node.sourceSpan);
+      }
+      _dartTagSeen = true;
+    }
+
     if (src == null) return;
-    var type = node.attributes['type'];
-    bool isDart = type == 'application/dart;component=1' ||
-        type == 'application/dart';
 
     if (src.endsWith('.dart') && !isDart) {
-      _logger.warning('Wrong script type, expected type="application/dart" '
-          'or type="application/dart;component=1".', span: node.sourceSpan);
+      _logger.warning('Wrong script type, expected type="application/dart".',
+          span: node.sourceSpan);
       return;
     }
 
     if (!src.endsWith('.dart') && isDart) {
-      _logger.warning('"$type" scripts should use the .dart file extension.',
-          span: node.sourceSpan);
+      _logger.warning('"application/dart" scripts should use the .dart file '
+          'extension.', span: node.sourceSpan);
       return;
     }
 
     if (node.innerHtml.trim() != '') {
       _logger.warning('script tag has "src" attribute and also has script '
           'text.', span: node.sourceSpan);
     }
   }
 
   /// Produces warnings for misuses of on-foo event handlers, and for instanting
@@ skipping 91 matching lines @@
 
     if (value.contains('(')) {
       _logger.warning('Invalid event handler body "$value". Declare a method '
           'in your custom element "void handlerName(event, detail, target)" '
           'and use the form $name="handlerName".',
           span: node.attributeSpans[name]);
     }
   }
 }
 
+const String ONLY_ONE_TAG =
+    'Only one "application/dart" script tag per document is allowed.';
+
 const String USE_POLYMER_HTML =
-    'To run a polymer application you need to include the following HTML '
-    'import: <link rel="import" href="packages/polymer/polymer.html">. This '
-    'will include the common polymer logic needed to boostrap your '
-    'application. The old style of initializing polymer with boot.js or '
-    'initPolymer are now deprecated. ';
+    'Besides the initPolymer invocation, to run a polymer application you need '
+    'to include the following HTML import: '
+    '<link rel="import" href="packages/polymer/polymer.html">. This will '
+    'include the common polymer logic needed to boostrap your application.';
 
+const String USE_INIT_DART =
+    'To run a polymer application, you need to call "initPolymer". You can '
+    'either include a generic script tag that does this for you:'
+    '\'<script type="application/dart">export "package:polymer/init.dart";'
+    '</script>\' or add your own script tag and call that function. '
+    'Make sure the script tag is placed after all HTML imports.';
+
+const String NO_DART_SCRIPT_AND_EXPERIMENTAL =
+    'The experimental bootstrap feature doesn\'t support script tags on '
+    'the main document (for now).';