Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4590)

Unified Diff: chrome/browser/metrics/metrics_service.h

Issue 293023005: Move MetricsService final log collection tasks to client. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_service.h
===================================================================
--- chrome/browser/metrics/metrics_service.h (revision 271878)
+++ chrome/browser/metrics/metrics_service.h (working copy)
@@ -404,13 +404,7 @@
// Starts the process of uploading metrics data.
void StartScheduledUpload();
- // Starts collecting any data that should be added to a log just before it is
- // closed.
- void StartFinalLogInfoCollection();
- // Callbacks for various stages of final log info collection. Do not call
- // these directly.
- void OnMemoryDetailCollectionDone();
- void OnHistogramSynchronizationDone();
+ // Called by the client when final log info collection is complete.
void OnFinalLogInfoCollectionDone();
// Either closes the current log or creates and closes the initial log
@@ -582,9 +576,6 @@
// This is used only for debugging.
bool waiting_for_asynchronous_reporting_step_;
- // Number of async histogram fetch requests in progress.
- int num_async_histogram_fetches_in_progress_;
-
// Stores the time of the first call to |GetUptimes()|.
base::TimeTicks first_updated_time_;

Powered by Google App Engine
This is Rietveld 408576698