Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: tools/dom/scripts/systemnative.py

Issue 293023002: Dartium 35: Suppress type signature on custom constructors (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sdk/lib/_blink/dartium/_blink_dartium.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 2 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
3 # for details. All rights reserved. Use of this source code is governed by a 3 # for details. All rights reserved. Use of this source code is governed by a
4 # BSD-style license that can be found in the LICENSE file. 4 # BSD-style license that can be found in the LICENSE file.
5 5
6 """This module provides shared functionality for the systems to generate 6 """This module provides shared functionality for the systems to generate
7 native binding from the IDL database.""" 7 native binding from the IDL database."""
8 8
9 import emitter 9 import emitter
10 import os 10 import os
(...skipping 587 matching lines...) Expand 10 before | Expand all | Expand 10 after
598 else: 598 else:
599 argument_count = len(arguments) 599 argument_count = len(arguments)
600 600
601 typed_formals = constructor_info.ParametersAsArgumentList(argument_count) 601 typed_formals = constructor_info.ParametersAsArgumentList(argument_count)
602 parameters = constructor_info.ParametersAsStringOfVariables(argument_count) 602 parameters = constructor_info.ParametersAsStringOfVariables(argument_count)
603 interface_name = self._interface_type_info.interface_name() 603 interface_name = self._interface_type_info.interface_name()
604 604
605 if self._dart_use_blink: 605 if self._dart_use_blink:
606 type_ids = [p.type.id for p in arguments[:argument_count]] 606 type_ids = [p.type.id for p in arguments[:argument_count]]
607 constructor_callback_id = \ 607 constructor_callback_id = \
608 DeriveResolverString(self._interface.id, cpp_suffix, None, type_ids) 608 DeriveResolverString(self._interface.id, cpp_suffix, None, type_ids, is_custom)
609 else: 609 else:
610 constructor_callback_id = self._interface.id + '_' + constructor_callbac k_cpp_name 610 constructor_callback_id = self._interface.id + '_' + constructor_callbac k_cpp_name
611 611
612 if self._dart_use_blink: 612 if self._dart_use_blink:
613 # First we emit the toplevel function 613 # First we emit the toplevel function
614 dart_native_name = \ 614 dart_native_name = \
615 DeriveNativeName(self._interface.id, constructor_callback_cpp_name, "") 615 DeriveNativeName(self._interface.id, constructor_callback_cpp_name, "")
616 if constructor_callback_id in _cpp_resolver_string_map: 616 if constructor_callback_id in _cpp_resolver_string_map:
617 constructor_callback_id = \ 617 constructor_callback_id = \
618 _cpp_resolver_string_map[constructor_callback_id] 618 _cpp_resolver_string_map[constructor_callback_id]
(...skipping 1354 matching lines...) Expand 10 before | Expand all | Expand 10 after
1973 e.Emit("};\n"); 1973 e.Emit("};\n");
1974 e.Emit('\n'); 1974 e.Emit('\n');
1975 e.Emit('} // namespace WebCore\n'); 1975 e.Emit('} // namespace WebCore\n');
1976 1976
1977 def _IsOptionalStringArgumentInInitEventMethod(interface, operation, argument): 1977 def _IsOptionalStringArgumentInInitEventMethod(interface, operation, argument):
1978 return ( 1978 return (
1979 interface.id.endswith('Event') and 1979 interface.id.endswith('Event') and
1980 operation.id.startswith('init') and 1980 operation.id.startswith('init') and
1981 argument.ext_attrs.get('Default') == 'Undefined' and 1981 argument.ext_attrs.get('Default') == 'Undefined' and
1982 argument.type.id == 'DOMString') 1982 argument.type.id == 'DOMString')
OLDNEW
« no previous file with comments | « sdk/lib/_blink/dartium/_blink_dartium.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698