Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2930153002: Disable dependency_graph_test on some platforms. (Closed)

Created:
3 years, 6 months ago by Bob Nystrom
Modified:
3 years, 6 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Disable dependency_graph_test on some platforms. Do to reorganizing some code, it now transitively imports mirrors, so don't run it on platforms that don't have mirrors. We only really care about this test on the standalone VM anyway. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/7a28d5a310eae8573175f4480ac313e71af30cb3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/standalone/standalone.status View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
3 years, 6 months ago (2017-06-10 00:03:30 UTC) #2
Emily Fortuna
lgtm
3 years, 6 months ago (2017-06-10 00:04:04 UTC) #3
Bob Nystrom
3 years, 6 months ago (2017-06-10 00:06:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7a28d5a310eae8573175f4480ac313e71af30cb3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698