Add DIRECT_COMPOSITION GpuMemoryBuffer type.

ui/gl/gl_image.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GL_GL_IMAGE_H_
 #define UI_GL_GL_IMAGE_H_
 
 #include <stdint.h>
 
 #include <string>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "ui/gfx/geometry/point.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/geometry/rect_f.h"
 #include "ui/gfx/geometry/size.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/gfx/overlay_transform.h"
 #include "ui/gl/gl_export.h"
 
 namespace base {
 namespace trace_event {
 class ProcessMemoryDump;
 }
 }
 
 namespace gl {
+class GLSurface;
 
 // Encapsulates an image that can be bound and/or copied to a texture, hiding
 // platform specific management.
 class GL_EXPORT GLImage : public base::RefCounted<GLImage> {
  public:
   GLImage() {}
 
   // Get the size of the image.
   virtual gfx::Size GetSize() = 0;
 
@@ skipping 47 matching lines @@
   // GL_RGBA. The client is responsible for implementing appropriate
   // workarounds. The only support that the command buffer provides is format
   // validation during calls to copyTexImage2D and copySubTexImage2D.
   //
   // This is a workaround that is not intended to become a permanent part of the
   // GLImage API. Theoretically, when Apple fixes their drivers, this can be
   // removed. https://crbug.com/581777#c36
   virtual bool EmulatingRGB() const;
 
   // An identifier for subclasses. Necessary for safe downcasting.
-  enum class Type { NONE, MEMORY, IOSURFACE, DXGI_IMAGE };
+  enum class Type { NONE, MEMORY, IOSURFACE, DXGI_IMAGE, DIRECT_COMPOSITION };

[reveman, 2017/06/14 21:35:59]

This type of downcasting is an indication that're not able to create the proper
API and abstraction for what we're trying to do. I think we should strive
towards being able to remove this. Is this really needed in the direct
composition case?

[jbauman, 2017/06/14 22:18:17]

I guess I could have windows-only GetSwapChain() and GetDCompositionSurface()
methods that would be implemented only by the DirectCompositionChildSurfaceWin,
if you want.

   virtual Type GetType() const;
 
+  virtual scoped_refptr<GLSurface> GetSurface();

[reveman, 2017/06/14 21:35:59]

How is this suppose to be used? Can we do something similar to
ScheduleOverlayPlane instead?

[jbauman, 2017/06/14 22:18:17]

This is actually going to be used to draw into the texture. The
DirectComposition surfaces can't really be used as FBOs, so we'll need to have a
new GL command that makes a GLImage current on the context. This will retrieve
the GLSurface that will actually be made current.

+
  protected:
   virtual ~GLImage() {}
 
  private:
   friend class base::RefCounted<GLImage>;
 
   DISALLOW_COPY_AND_ASSIGN(GLImage);
 };
 
 }  // namespace gl
 
 #endif  // UI_GL_GL_IMAGE_H_