Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: tools/dartium/multivm_archive.py

Issue 293013003: Fix archive uploader bug. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dartium/multivm_archive.py
diff --git a/tools/dartium/multivm_archive.py b/tools/dartium/multivm_archive.py
index 6b3877cba414e428f22793b289714961974a9bd5..601adc37304693bbd8ea1c28fc29337e5ef60311 100644
--- a/tools/dartium/multivm_archive.py
+++ b/tools/dartium/multivm_archive.py
@@ -22,14 +22,13 @@ import upload_steps
SRC_PATH = dartium_bot_utils.srcPath()
def main():
- print SRC_PATH
multivm_deps = os.path.join(os.path.dirname(SRC_PATH), 'multivm.deps')
revision_directory = (multivm_deps if (os.path.isdir(multivm_deps))
else os.path.join(SRC_PATH, 'dart'))
output, _ = subprocess.Popen(['svn', 'info'],
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
- shell=(platform.system == 'Windows'),
+ shell=(platform.system() == 'Windows'),
ricow1 2014/05/21 07:47:06 why do we need that?
Bill Hesse 2014/05/21 08:18:39 Looking up the svn executable on the path, from th
cwd=revision_directory).communicate()
revision = re.search('Last Changed Rev: (\d+)', output).group(1)
version = revision + '.0'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698