Tablet WM : Swiping on system tray bubble.

ash/system/tray/tray_event_filter.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/tray/tray_event_filter.h"
 
 #include "ash/public/cpp/shell_window_ids.h"
+#include "ash/shell.h"
 #include "ash/shell_port.h"
 #include "ash/system/tray/tray_background_view.h"
 #include "ash/system/tray/tray_bubble_wrapper.h"
 #include "ash/wm/container_finder.h"
+#include "ash/wm/maximize_mode/maximize_mode_controller.h"
 #include "ui/aura/window.h"
 #include "ui/views/widget/widget.h"
 
 namespace ash {
 
 TrayEventFilter::TrayEventFilter() {}
 
 TrayEventFilter::~TrayEventFilter() {
   DCHECK(wrappers_.empty());
 }
@@ skipping 44 matching lines @@
   // happens inside of any of those wrappers.
   for (std::set<TrayBubbleWrapper*>::const_iterator iter = wrappers_.begin();
        iter != wrappers_.end(); ++iter) {
     const TrayBubbleWrapper* wrapper = *iter;
     const views::Widget* bubble_widget = wrapper->bubble_widget();
     if (!bubble_widget)
       continue;
 
     gfx::Rect bounds = bubble_widget->GetWindowBoundsInScreen();
     bounds.Inset(wrapper->bubble_view()->GetBorderInsets());
+    // System tray can be dragged to show the bubble if it is in maximize mode.
+    // The events happened on the clipped part of the bubble should be considerd
+    // happened outside the bubble.

[tdanderson, 2017/06/26 18:13:02]

Suggestion to re-word the second sentence: "During the drag, the bubble's
logical bounds can extend outside of the work area, but its visual bounds are
only within the work area. Restrict |bounds| so that events located outside the
bubble's visual bounds are treated as outside of the bubble."

Does that make sense / reflect what is happening here?

[minch1, 2017/06/26 23:26:48]

Yes, thanks.

+    if (Shell::Get()
+            ->maximize_mode_controller()
+            ->IsMaximizeModeWindowManagerEnabled()) {

[tdanderson, 2017/06/26 18:13:02]

Do you intentionally not check container_id ==
kShellWindowId_SettingBubbleContainer here since for all other containers the
intersection on line 84 would just be a no-op?

[minch1, 2017/06/26 23:26:49]

I don't think that for all the other containers the intersection with the work
area is just the original |bounds| (all is in work area). So I think it should
be better to add the container_id restriction here.Thanks.

+      bounds.Intersect(bubble_widget->GetWorkAreaBoundsInScreen());
+    }
     if (bounds.Contains(location_in_screen))
       continue;
     if (wrapper->tray()) {
       // If the user clicks on the parent tray, don't process the event here,
       // let the tray logic handle the event and determine show/hide behavior.
       bounds = wrapper->tray()->GetBoundsInScreen();
       if (bounds.Contains(location_in_screen))
         continue;
     }
     trays.insert((*iter)->tray());
   }
 
   // Close all bubbles other than the one a user clicked on the tray
   // or its bubble.
   for (std::set<TrayBackgroundView*>::iterator iter = trays.begin();
        iter != trays.end(); ++iter) {
     (*iter)->ClickedOutsideBubble();
   }
 }
 
 }  // namespace ash