Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: components/security_interstitials/core/safe_browsing_quiet_error_ui.cc

Issue 2930043002: Implement V2 design for quiet safe browsing interstitial (Closed)
Patch Set: Remove extra break Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_interstitials/core/safe_browsing_quiet_error_ui.cc
diff --git a/components/security_interstitials/core/safe_browsing_quiet_error_ui.cc b/components/security_interstitials/core/safe_browsing_quiet_error_ui.cc
index 6afb802058e5651abfc05c729f0e0b2e4edbf191..c7e9a8006a46e3f370331d4a831f97c56a4f0467 100644
--- a/components/security_interstitials/core/safe_browsing_quiet_error_ui.cc
+++ b/components/security_interstitials/core/safe_browsing_quiet_error_ui.cc
@@ -90,7 +90,34 @@ void SafeBrowsingQuietErrorUI::SetGiantWebViewForTesting(
void SafeBrowsingQuietErrorUI::HandleCommand(
SecurityInterstitialCommands command) {
- NOTREACHED();
+ switch (command) {
+ case CMD_PROCEED: {
+ // User pressed on the button to proceed.
+ if (!is_proceed_anyway_disabled()) {
+ controller()->metrics_helper()->RecordUserDecision(
+ MetricsHelper::PROCEED);
+ controller()->Proceed();
+ }
+ break;
+ }
+ case CMD_DONT_PROCEED:
+ case CMD_DO_REPORT:
+ case CMD_DONT_REPORT:
+ case CMD_SHOW_MORE_SECTION:
+ case CMD_OPEN_HELP_CENTER:
+ case CMD_RELOAD:
+ case CMD_OPEN_REPORTING_PRIVACY:
+ case CMD_OPEN_WHITEPAPER:
+ case CMD_OPEN_DIAGNOSTIC:
+ case CMD_REPORT_PHISHING_ERROR:
+ case CMD_OPEN_DATE_SETTINGS:
+ case CMD_OPEN_LOGIN:
+ case CMD_ERROR:
+ case CMD_TEXT_FOUND:
+ case CMD_TEXT_NOT_FOUND:
+ NOTREACHED();
+ break;
+ }
}
int SafeBrowsingQuietErrorUI::GetHTMLTemplateId() const {

Powered by Google App Engine
This is Rietveld 408576698