Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: components/security_interstitials/core/browser/resources/interstitial_mobile_nav.js

Issue 2930043002: Implement V2 design for quiet safe browsing interstitial (Closed)
Patch Set: Remove extra break Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_interstitials/core/browser/resources/interstitial_mobile_nav.js
diff --git a/components/security_interstitials/core/browser/resources/interstitial_mobile_nav.js b/components/security_interstitials/core/browser/resources/interstitial_mobile_nav.js
index 655d91f33be946688b3bcb430465bd25d5ab357c..433977e2a786631c637c390e7fb816c846fe9439 100644
--- a/components/security_interstitials/core/browser/resources/interstitial_mobile_nav.js
+++ b/components/security_interstitials/core/browser/resources/interstitial_mobile_nav.js
@@ -16,7 +16,7 @@ function onResize() {
'(max-height: 560px) and (min-height: 240px) and ' +
'(min-width: 421px)';
- var detailsHidden = helpOuterBox.classList.contains('hidden');
+ var detailsHidden = helpOuterBox.classList.contains(HIDDEN_CLASS);
var runnerContainer = document.querySelector('.runner-container');
// Check for change in nav status.
@@ -25,17 +25,17 @@ function onResize() {
// Handle showing the top content / details sections according to state.
if (mobileNav) {
- mainContent.classList.toggle('hidden', !detailsHidden);
- helpOuterBox.classList.toggle('hidden', detailsHidden);
+ mainContent.classList.toggle(HIDDEN_CLASS, !detailsHidden);
+ helpOuterBox.classList.toggle(HIDDEN_CLASS, detailsHidden);
if (runnerContainer) {
- runnerContainer.classList.toggle('hidden', !detailsHidden);
+ runnerContainer.classList.toggle(HIDDEN_CLASS, !detailsHidden);
}
} else if (!detailsHidden) {
// Non mobile nav with visible details.
- mainContent.classList.remove('hidden');
- helpOuterBox.classList.remove('hidden');
+ mainContent.classList.remove(HIDDEN_CLASS);
+ helpOuterBox.classList.remove(HIDDEN_CLASS);
if (runnerContainer) {
- runnerContainer.classList.remove('hidden');
+ runnerContainer.classList.remove(HIDDEN_CLASS);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698