Make ActiveScriptController use Active Tab-style permissions

extensions/common/permissions/permissions_data.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_PERMISSIONS_PERMISSIONS_DATA_H_
 #define EXTENSIONS_COMMON_PERMISSIONS_PERMISSIONS_DATA_H_
 
 #include <map>
 #include <vector>
 
@@ skipping 72 matching lines @@
       int tab_id);
   // Updates the tab-specific permissions of |tab_id| to include those from
   // |permissions|.
   static void UpdateTabSpecificPermissions(
       const Extension* extension,
       int tab_id,
       scoped_refptr<const PermissionSet> permissions);
   // Clears the tab-specific permissions of |tab_id|.
   static void ClearTabSpecificPermissions(const Extension* extension,
                                           int tab_id);
+  // Returns true if the |extension| has tab-specific permission to operate on
+  // the tab specified by |tab_id| with the given |url|.
+  // Note that if this returns false, it doesn't mean the extension can't run on
+  // the given tab, only that it does not have tab-specific permission to do so.
+  static bool HasTabSpecificPermission(const Extension* extension,

[not at google - send to devlin, 2014/05/21 20:10:20]

this is not something I particularly want to expose on the public interface of
this class, but it looks like it doesn't need to be.

[Devlin, 2014/05/21 23:16:07]

Done.

+                                       int tab_id,
+                                       const GURL& url);
 
   // Returns true if the |extension| has the given |permission|. Prefer
   // IsExtensionWithPermissionOrSuggestInConsole when developers may be using an
   // api that requires a permission they didn't know about, e.g. open web apis.
   // Note this does not include APIs with no corresponding permission, like
   // "runtime" or "browserAction".
   // TODO(mpcomplete): drop the "API" from these names, it's confusing.
   static bool HasAPIPermission(const Extension* extension,
                                APIPermission::ID permission);
   static bool HasAPIPermission(const Extension* extension,
@@ skipping 25 matching lines @@
   // Whether the |extension| has access to the given |url|.
   static bool HasHostPermission(const Extension* extension, const GURL& url);
 
   // Whether the |extension| has effective access to all hosts. This is true if
   // there is a content script that matches all hosts, if there is a host
   // permission grants access to all hosts (like <all_urls>) or an api
   // permission that effectively grants access to all hosts (e.g. proxy,
   // network, etc.)
   static bool HasEffectiveAccessToAllHosts(const Extension* extension);
 
+  // Whether the extension has access to so many hosts that we should treat it
+  // as "all_hosts" for warning purposes.
+  // For example, '*://*.com/*'.
+  static bool HasAccessToMostHosts(const Extension* extension);

[not at google - send to devlin, 2014/05/21 20:10:20]

same comment as the other HasAccessToMostHosts

[Devlin, 2014/05/21 23:16:07]

Done.

+
   // Returns the full list of permission messages that the given |extension|
   // should display at install time.
   static PermissionMessages GetPermissionMessages(const Extension* extension);
   // Returns the full list of permission messages that the given |extension|
   // should display at install time. The messages are returned as strings
   // for convenience.
   static std::vector<base::string16> GetPermissionMessageStrings(
       const Extension* extension);
 
   // Returns the full list of permission details for messages that the given
@@ skipping 24 matching lines @@
   // Returns true if the |extension| is allowed to obtain the contents of a
   // page as an image.  Since a page may contain sensitive information, this
   // is restricted to the extension's host permissions as well as the
   // extension page itself.
   static bool CanCaptureVisiblePage(const Extension* extension,
                                     int tab_id,
                                     std::string* error);
 
   // Returns true if the user should be alerted that the |extension| is running
   // a script.
-  static bool RequiresActionForScriptExecution(const Extension* extension);
+  static bool RequiresActionForScriptExecution(const Extension* extension,
+                                               int tab_id,
+                                               const GURL& document_url);
 
   // Parse the permissions of a given extension in the initialization process.
   bool ParsePermissions(Extension* extension, base::string16* error);
 
   // Ensure manifest handlers provide their custom manifest permissions.
   void InitializeManifestPermissions(Extension* extension);
 
   // Finalize permissions after the initialization process completes.
   void FinalizePermissions(Extension* extension);
 
@@ skipping 19 matching lines @@
   mutable scoped_refptr<const PermissionSet> active_permissions_;
 
   mutable TabPermissionsMap tab_specific_permissions_;
 
   DISALLOW_COPY_AND_ASSIGN(PermissionsData);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_PERMISSIONS_PERMISSIONS_DATA_H_