Make ActiveScriptController use Active Tab-style permissions

extensions/common/permissions/permission_set.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_PERMISSIONS_PERMISSION_SET_H_
 #define EXTENSIONS_COMMON_PERMISSIONS_PERMISSION_SET_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 78 matching lines @@
   // Returns true if this includes permission to access |origin|.
   bool HasExplicitAccessToOrigin(const GURL& origin) const;
 
   // Returns true if this permission set includes access to script |url|.
   bool HasScriptableAccessToURL(const GURL& url) const;
 
   // Returns true if this permission set includes effective access to all
   // origins.
   bool HasEffectiveAccessToAllHosts() const;
 
+  // Returns true if this permission set has access to so many hosts, that we

[not at google - send to devlin, 2014/05/21 20:10:20]

Can we call this ShouldWarnForAllHosts then? "most" hosts is pretty vague, and
probably not even correct.

[Devlin, 2014/05/21 23:16:07]

Done.

+  // should treat it as all hosts for warning purposes.
+  // For example, '*://*.com/*'.
+  bool HasAccessToMostHosts() const;
+
   // Returns true if this permission set includes effective access to |url|.
   bool HasEffectiveAccessToURL(const GURL& url) const;
 
   // Returns true if this permission set effectively represents full access
   // (e.g. native code).
   bool HasEffectiveFullAccess() const;
 
   const APIPermissionSet& apis() const { return apis_; }
 
   const ManifestPermissionSet& manifest_permissions() const {
       return manifest_permissions_;
   }
 
   const URLPatternSet& effective_hosts() const { return effective_hosts_; }
 
   const URLPatternSet& explicit_hosts() const { return explicit_hosts_; }
 
   const URLPatternSet& scriptable_hosts() const { return scriptable_hosts_; }
 
  private:
   FRIEND_TEST_ALL_PREFIXES(PermissionsTest, GetWarningMessages_AudioVideo);
   friend class base::RefCountedThreadSafe<PermissionSet>;
 
   ~PermissionSet();
 
-  void AddAPIPermission(APIPermission::ID id);
-
   // Adds permissions implied independently of other context.
   void InitImplicitPermissions();
 
   // Initializes the effective host permission based on the data in this set.
   void InitEffectiveHosts();
 
+  // Initializes |has_access_to_most_hosts_|.
+  void InitHasAccessToMostHosts() const;
+
   // The api list is used when deciding if an extension can access certain
   // extension APIs and features.
   APIPermissionSet apis_;
 
   // The manifest key permission list is used when deciding if an extension
   // can access certain extension APIs and features.
   ManifestPermissionSet manifest_permissions_;
 
   // The list of hosts that can be accessed directly from the extension.
   // TODO(jstritar): Rename to "hosts_"?
   URLPatternSet explicit_hosts_;
 
   // The list of hosts that can be scripted by content scripts.
   // TODO(jstritar): Rename to "user_script_hosts_"?
   URLPatternSet scriptable_hosts_;
 
   // The list of hosts this effectively grants access to.
   URLPatternSet effective_hosts_;
+
+  // Whether or not this permission set includes access to so many origins, we
+  // should treat it as all_hosts for warning purposes.
+  // Lazily set upon first retrieval, and stored for performance sake.
+  // Mutable, because setting this does not change the logical state of the
+  // permission set, and is done only for performance purposes.
+  mutable scoped_ptr<bool> has_access_to_most_hosts_;

[not at google - send to devlin, 2014/05/21 20:10:20]

a pointer for this seems like overkill. could you make it a tri-state enum?

[Devlin, 2014/05/21 23:16:07]

Why not.

 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_PERMISSIONS_PERMISSION_SET_H_