Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 293003004: Prevents WebURLLoaderMock to crash when didReceiveResponse calls ::cancel(). (Closed)

Created:
6 years, 7 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 6 months ago
Reviewers:
jam, Paweł Hajdan Jr.
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@manifest_chrame
Visibility:
Public.

Description

Prevents WebURLLoaderMock to crash when didReceiveResponse calls ::cancel(). The fix is a bit dirty but it should work and is straightforward. The clean solution would involve more changes on the Blink side or some wrapping of objects in WebURLLoaderMock. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274758

Patch Set 1 #

Patch Set 2 : apply jam comments #

Patch Set 3 : remove changes from other cl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M content/test/weburl_loader_mock.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/test/weburl_loader_mock.cc View 1 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
mlamouri (slow - plz ping)
6 years, 7 months ago (2014-05-20 19:16:14 UTC) #1
Paweł Hajdan Jr.
Is this fixing some bug? I'd prefer someone working more closely with this code to ...
6 years, 7 months ago (2014-05-21 09:38:40 UTC) #2
mlamouri (slow - plz ping)
On 2014/05/21 09:38:40, Paweł Hajdan Jr. wrote: > Is this fixing some bug? > > ...
6 years, 7 months ago (2014-05-21 09:41:40 UTC) #3
mlamouri (slow - plz ping)
jam@, do you think you can have a look at that?
6 years, 6 months ago (2014-06-03 20:58:21 UTC) #4
jam
lgtm
6 years, 6 months ago (2014-06-03 21:34:59 UTC) #5
mlamouri (slow - plz ping)
On 2014/06/03 21:34:59, jam wrote: > lgtm Thanks :)
6 years, 6 months ago (2014-06-03 21:35:19 UTC) #6
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-06-03 21:35:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/293003004/40001
6 years, 6 months ago (2014-06-03 21:36:52 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 09:29:41 UTC) #9
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-06-04 09:39:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/293003004/40001
6 years, 6 months ago (2014-06-04 09:40:17 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 10:54:26 UTC) #12
Message was sent while issue was closed.
Change committed as 274758

Powered by Google App Engine
This is Rietveld 408576698