Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp - Issue 293003003: Drop useless String::isNull() check in V8CSSStyleDeclaration::namedPropertyGetterCustom()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

Issue 293003003: Drop useless String::isNull() check in V8CSSStyleDeclaration::namedPropertyGetterCustom() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

diff --git a/Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp b/Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

index 95f141ec81f698c1c584ba959ab321e938778805..e10ce6cff86978c50927915abed29671bd92369a 100644

--- a/Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

+++ b/Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

@@ -210,9 +210,6 @@ void V8CSSStyleDeclaration::namedPropertyGetterCustom(v8::Local<v8::String> name

}

String result = impl->getPropertyValueInternal(static_cast<CSSPropertyID>(propInfo->propID));

- if (result.isNull())

- result = ""; // convert null to empty string.

v8SetReturnValueString(info, result, info.GetIsolate());

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »