Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 2930013005: [Tab Metrics] Measure FP, FCP and FMP for Foreground Tab during Session Restore (Closed)
Patch Set: Address Bryan comments Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
index 32b78352152f0c1486a6a3b4b79d8304b8f0869d..774715f516202a439e427d77493bc72355d0f2b5 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
@@ -10,10 +10,8 @@
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/timer/timer.h"
+#include "build/build_config.h"
#include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
-#if defined(OS_ANDROID)
-#include "chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.h"
-#endif // OS_ANDROID
#include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h"
#include "chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h"
#include "chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h"
@@ -50,6 +48,12 @@
#include "content/public/browser/web_contents.h"
#include "url/gurl.h"
+#if defined(OS_ANDROID)
+#include "chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.h"
+#else
+#include "chrome/browser/page_load_metrics/observers/session_restore_page_load_metrics_observer.h"
+#endif
+
namespace chrome {
namespace {
@@ -137,6 +141,10 @@ void PageLoadMetricsEmbedder::RegisterObservers(
web_contents_);
if (loading_predictor_observer)
tracker->AddObserver(std::move(loading_predictor_observer));
+#if !defined(OS_ANDROID)
+ tracker->AddObserver(
+ base::MakeUnique<SessionRestorePageLoadMetricsObserver>());
+#endif
tracker->AddObserver(
base::MakeUnique<LocalNetworkRequestsPageLoadMetricsObserver>());
} else {

Powered by Google App Engine
This is Rietveld 408576698