[Tab Metrics] Measure FP, FCP and FMP for Foreground Tab during Session Restore

chrome/browser/page_load_metrics/observers/session_restore_foreground_tab_page_load_metrics_observer_unittest.cc

Index: chrome/browser/page_load_metrics/observers/session_restore_foreground_tab_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/session_restore_foreground_tab_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/session_restore_foreground_tab_page_load_metrics_observer_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d0cbf7c9326c612b35d0f750ce9bf394e1a6c8a5
--- /dev/null
+++ b/chrome/browser/page_load_metrics/observers/session_restore_foreground_tab_page_load_metrics_observer_unittest.cc
@@ -0,0 +1,148 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/page_load_metrics/observers/session_restore_foreground_tab_page_load_metrics_observer.h"
+
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h"
+#include "chrome/browser/sessions/tab_loader.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/tabs/test_tab_strip_model_delegate.h"
+#include "chrome/test/base/testing_profile.h"
+
+using RestoredTab = SessionRestoreDelegate::RestoredTab;
+
+namespace {
+
+const char kDefaultTestUrl[] = "https://google.com";
+
+}  // namepsace
+
+class SessionRestoreForegroundTabPageLoadMetricsObserverTest
+    : public page_load_metrics::PageLoadMetricsObserverTestHarness {
+ protected:
+  void RegisterObservers(page_load_metrics::PageLoadTracker* tracker) override {
+    std::unique_ptr<SessionRestoreForegroundTabPageLoadMetricsObserver>
+        observer = SessionRestoreForegroundTabPageLoadMetricsObserver::
+            CreateIfNeeded();
+    if (observer)
+      tracker->AddObserver(std::move(observer));
+  }
+
+  void SetUp() override {
+    page_load_metrics::PageLoadMetricsObserverTestHarness::SetUp();
+    PopulateAllFirstPaintTimings(&timing_);
+  }
+
+  // Populate first paint and first [contentful,meaningful] paint timings
+  void PopulateAllFirstPaintTimings(
+      page_load_metrics::mojom::PageLoadTiming* timing_) {
+    page_load_metrics::InitPageLoadTimingForTest(timing_);
+    timing_->navigation_start = base::Time::FromDoubleT(1);
+    timing_->paint_timing->first_meaningful_paint =
+        base::TimeDelta::FromMilliseconds(10);
+    PopulateRequiredTimingFields(timing_);
+  }
+
+  void ExpectFirstPaintMetricsTotalCount(int expected_total_count) {
+    histogram_tester().ExpectTotalCount(
+        internal::kHistogramSessionRestoreForegroundTabFirstPaint,
+        expected_total_count);
+    histogram_tester().ExpectTotalCount(
+        internal::kHistogramSessionRestoreForegroundTabFirstContentfulPaint,
+        expected_total_count);
+    histogram_tester().ExpectTotalCount(
+        internal::kHistogramSessionRestoreForegroundTabFirstMeaningfulPaint,
+        expected_total_count);
+  }
+
+  page_load_metrics::mojom::PageLoadTiming timing_;
+};
+
+TEST_F(SessionRestoreForegroundTabPageLoadMetricsObserverTest, NoMetrics) {
+  ExpectFirstPaintMetricsTotalCount(0);
+}
+
+TEST_F(SessionRestoreForegroundTabPageLoadMetricsObserverTest,
+       FirstPaintsOutOfSessionRestore) {
+  NavigateAndCommit(GURL(kDefaultTestUrl));
+  SimulateTimingUpdate(timing_);
+
+  ExpectFirstPaintMetricsTotalCount(0);
+}
+
+TEST_F(SessionRestoreForegroundTabPageLoadMetricsObserverTest,
+       InitialActiveTabChanged) {
+  TestTabStripModelDelegate tab_strip_delegate;
+  TabStripModel tab_strip(&tab_strip_delegate, profile());
+  tab_strip.AddObserver(g_browser_process->GetTabManager());
+
+  std::unique_ptr<content::WebContents> test_contents(CreateTestWebContents());
+  std::vector<RestoredTab> restored_tabs{
+      RestoredTab(test_contents.get(), false, false, false),
+      RestoredTab(web_contents(), false, false, false)};
+
+  // Tab strip with 2 tabs: tab 0 is foreground, tab 1 is background
+  tab_strip.AppendWebContents(restored_tabs[0].contents(), true);
+  tab_strip.AppendWebContents(restored_tabs[1].contents(), false);
+
+  TabLoader::RestoreTabs(restored_tabs, base::TimeTicks());
+
+  // Start loading tab 0 but do not complete loading it
+  content::WebContentsTester::For(restored_tabs[0].contents())
+      ->NavigateAndCommit(GURL(kDefaultTestUrl));
+
+  // Switch to tab 1 and load it completely
+  tab_strip.ActivateTabAt(1, true);
+  NavigateAndCommit(GURL(kDefaultTestUrl));
+  SimulateTimingUpdate(timing_);
+
+  // No paint timings recorded because the initial active tab was changed

[chrisha, 2017/06/21 15:00:26]

Missing period.

[ducbui, 2017/06/27 19:41:24]

Done.

+  ExpectFirstPaintMetricsTotalCount(0);
+}
+
+TEST_F(SessionRestoreForegroundTabPageLoadMetricsObserverTest,
+       ForegroundTabInSessionRestore) {
+  std::vector<SessionRestoreDelegate::RestoredTab> restored_tabs{
+      SessionRestoreDelegate::RestoredTab(web_contents(), false, false, false)};
+
+  // Restore one tab which finishes loading in foreground
+  TabLoader::RestoreTabs(restored_tabs, base::TimeTicks());
+  NavigateAndCommit(GURL(kDefaultTestUrl));
+  SimulateTimingUpdate(timing_);
+
+  ExpectFirstPaintMetricsTotalCount(1);
+}
+
+TEST_F(SessionRestoreForegroundTabPageLoadMetricsObserverTest,
+       BackgroundTabInSessionRestore) {
+  // Set the tab to background before the PageLoadMetricsObserver was created

[chrisha, 2017/06/21 15:00:26]

Ditto, for all comments in this file.

[ducbui, 2017/06/27 19:41:24]

Done.

+  web_contents()->WasHidden();
+
+  std::vector<RestoredTab> restored_tabs{
+      RestoredTab(web_contents(), false, false, false)};
+
+  // Load the restored tab in background
+  TabLoader::RestoreTabs(restored_tabs, base::TimeTicks());
+  NavigateAndCommit(GURL(kDefaultTestUrl));
+  SimulateTimingUpdate(timing_);
+
+  // No paint timings recorded because the loaded tab was in background
+  ExpectFirstPaintMetricsTotalCount(0);
+}
+
+TEST_F(SessionRestoreForegroundTabPageLoadMetricsObserverTest,
+       TabIsHiddenBeforeFirstPaints) {
+  std::vector<RestoredTab> restored_tabs{
+      RestoredTab(web_contents(), false, false, false)};
+  TabLoader::RestoreTabs(restored_tabs, base::TimeTicks());
+
+  // Hide the tab after the PageLoadMetricsObserver was created
+  NavigateAndCommit(GURL(kDefaultTestUrl));
+  web_contents()->WasHidden();
+  SimulateTimingUpdate(timing_);
+
+  // No paint timings recorded because tab was hidden before the first paints
+  ExpectFirstPaintMetricsTotalCount(0);
+}