chrome/browser/page_load_metrics/page_load_metrics_initialize.cc - Issue 2930013005: [Tab Metrics] Measure FP, FCP and FMP for Foreground Tab during Session Restore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 2930013005: [Tab Metrics] Measure FP, FCP and FMP for Foreground Tab during Session Restore (Closed)

Patch Set: Fix a typo Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

index 32b78352152f0c1486a6a3b4b79d8304b8f0869d..be370edeae86952b0a5155b5def106adee2f9044 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

@@ -10,6 +10,7 @@

#include "base/macros.h"

#include "base/memory/ptr_util.h"

#include "base/timer/timer.h"

+#include "build/build_config.h"

#include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"

#if defined(OS_ANDROID)

#include "chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.h"

@@ -37,6 +38,9 @@

#include "chrome/browser/page_load_metrics/observers/previews_ukm_observer.h"

#include "chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h"

+#if !defined(OS_ANDROID)

Charlie Harrison 2017/08/09 02:42:05 nit: platform specific includes go in a separate s

ducbui 2017/08/09 03:25:21 Done.

+#include "chrome/browser/page_load_metrics/observers/session_restore_page_load_metrics_observer.h"

+#endif // OS_ANDROID

#include "chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h"

@@ -137,6 +141,10 @@ void PageLoadMetricsEmbedder::RegisterObservers(

web_contents_);

if (loading_predictor_observer)

tracker->AddObserver(std::move(loading_predictor_observer));

+#if !defined(OS_ANDROID)

+ tracker->AddObserver(

+ base::MakeUnique<SessionRestorePageLoadMetricsObserver>());

+#endif

tracker->AddObserver(

base::MakeUnique<LocalNetworkRequestsPageLoadMetricsObserver>());

} else {