chrome/browser/sessions/tab_loader.cc - Issue 2930013005: [Tab Metrics] Measure FP, FCP and FMP for Foreground Tab during Session Restore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/tab_loader.cc

Issue 2930013005: [Tab Metrics] Measure FP, FCP and FMP for Foreground Tab during Session Restore (Closed)

Patch Set: Add RemoveFromWebContents() to RestoreOrigin. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sessions/tab_loader.cc

diff --git a/chrome/browser/sessions/tab_loader.cc b/chrome/browser/sessions/tab_loader.cc

index 69027ecf9dcd46d2be10e74f403058704ab62937..c132a5a2132897a5c250641f2ba8090cf80dced3 100644

--- a/chrome/browser/sessions/tab_loader.cc

+++ b/chrome/browser/sessions/tab_loader.cc

@@ -228,6 +228,8 @@ void TabLoader::RemoveTab(NavigationController* controller) {

registrar_.Remove(this, content::NOTIFICATION_LOAD_STOP,

content::Source<NavigationController>(controller));

+ RestoreOrigin::RemoveFromWebContents(controller->GetWebContents());

TabsLoading::iterator i = tabs_loading_.find(controller);

if (i != tabs_loading_.end())

tabs_loading_.erase(i);