Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Unified Diff: chrome/browser/page_load_metrics/observers/session_restore_page_load_metrics_observer.cc

Issue 2930013005: [Tab Metrics] Measure FP, FCP and FMP for Foreground Tab during Session Restore (Closed)
Patch Set: Add RemoveFromWebContents() to RestoreOrigin. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/session_restore_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/session_restore_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/session_restore_page_load_metrics_observer.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b1db3ffdb6aa83bdac3e3dc4111b13d8cbd58839
--- /dev/null
+++ b/chrome/browser/page_load_metrics/observers/session_restore_page_load_metrics_observer.cc
@@ -0,0 +1,119 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/page_load_metrics/observers/session_restore_page_load_metrics_observer.h"
+
+#include "base/logging.h"
+#include "base/memory/ptr_util.h"
+#include "base/metrics/histogram_macros.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/page_load_metrics/page_load_metrics_util.h"
+#include "chrome/browser/resource_coordinator/tab_manager.h"
+#include "chrome/browser/sessions/session_restore.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_finder.h"
+#include "content/public/browser/navigation_handle.h"
+#include "content/public/browser/render_widget_host_view.h"
+#include "content/public/browser/restore_type.h"
+#include "content/public/browser/web_contents.h"
+#include "ui/base/page_transition_types.h"
+#include "url/gurl.h"
+
+namespace internal {
+
+const char kHistogramSessionRestoreForegroundTabFirstPaint[] =
+ "TabManager.Experimental.SessionRestore.ForegroundTab.FirstPaint";
+const char kHistogramSessionRestoreForegroundTabFirstContentfulPaint[] =
+ "TabManager.Experimental.SessionRestore.ForegroundTab.FirstContentfulPaint";
+const char kHistogramSessionRestoreForegroundTabFirstMeaningfulPaint[] =
+ "TabManager.Experimental.SessionRestore.ForegroundTab.FirstMeaningfulPaint";
+
+} // namespace internal
+
+// static
+std::unique_ptr<SessionRestorePageLoadMetricsObserver>
+SessionRestorePageLoadMetricsObserver::CreateIfNeeded() {
+ resource_coordinator::TabManager* tab_manager =
+ g_browser_process->GetTabManager();
+ return tab_manager && tab_manager->IsSessionRestoreLoadingTabs() &&
+ !tab_manager->HasSessionRestoreInitialForegroundTabChanged()
+ ? base::MakeUnique<SessionRestorePageLoadMetricsObserver>()
+ : nullptr;
+}
+
+SessionRestorePageLoadMetricsObserver::SessionRestorePageLoadMetricsObserver() {
+}
+
+page_load_metrics::PageLoadMetricsObserver::ObservePolicy
+SessionRestorePageLoadMetricsObserver::OnStart(
+ content::NavigationHandle* navigation_handle,
+ const GURL& currently_committed_url,
+ bool started_in_foreground) {
+ // A non-empty currently-committed URL in the hosting tab indicates that
+ // there was a previous page load in this tab, and thus this load can't be a
+ // session restore.
+ if (!currently_committed_url.is_empty() || !started_in_foreground) {
+ return STOP_OBSERVING;
+ }
+
+ // This can be true when navigating from a restored internal-url tab or the
+ // user navigates before the previous navigation commits.
+ if (navigation_handle->GetRestoreType() !=
+ content::RestoreType::LAST_SESSION_EXITED_CLEANLY &&
+ navigation_handle->GetRestoreType() !=
+ content::RestoreType::LAST_SESSION_CRASHED) {
+ return STOP_OBSERVING;
+ }
+
+ RestoreOrigin* restore_origin =
+ RestoreOrigin::FromWebContents(navigation_handle->GetWebContents());
+ if (!restore_origin ||
+ restore_origin->type() != RestoreOrigin::Type::SESSION_RESTORE) {
+ return STOP_OBSERVING;
+ }
+
+ return CONTINUE_OBSERVING;
+}
+
+page_load_metrics::PageLoadMetricsObserver::ObservePolicy
+SessionRestorePageLoadMetricsObserver::OnCommit(
+ content::NavigationHandle* navigation_handle,
+ ukm::SourceId source_id) {
+ // Session restores use transition reload, so we only observe loads with a
+ // reload transition type.
+ DCHECK(ui::PageTransitionCoreTypeIs(navigation_handle->GetPageTransition(),
+ ui::PAGE_TRANSITION_RELOAD));
+ return CONTINUE_OBSERVING;
+}
+
+page_load_metrics::PageLoadMetricsObserver::ObservePolicy
+SessionRestorePageLoadMetricsObserver::OnHidden(
+ const page_load_metrics::mojom::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) {
+ return STOP_OBSERVING;
+}
+
+void SessionRestorePageLoadMetricsObserver::OnFirstPaintInPage(
+ const page_load_metrics::mojom::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& extra_info) {
+ PAGE_LOAD_HISTOGRAM(internal::kHistogramSessionRestoreForegroundTabFirstPaint,
+ timing.paint_timing->first_paint.value());
+}
+
+void SessionRestorePageLoadMetricsObserver::OnFirstContentfulPaintInPage(
+ const page_load_metrics::mojom::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& extra_info) {
+ PAGE_LOAD_HISTOGRAM(
+ internal::kHistogramSessionRestoreForegroundTabFirstContentfulPaint,
+ timing.paint_timing->first_contentful_paint.value());
+}
+
+void SessionRestorePageLoadMetricsObserver::
+ OnFirstMeaningfulPaintInMainFrameDocument(
+ const page_load_metrics::mojom::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& extra_info) {
+ PAGE_LOAD_HISTOGRAM(
+ internal::kHistogramSessionRestoreForegroundTabFirstMeaningfulPaint,
+ timing.paint_timing->first_meaningful_paint.value());
+}

Powered by Google App Engine
This is Rietveld 408576698