chrome/browser/page_load_metrics/page_load_metrics_initialize.cc - Issue 2930013005: [Tab Metrics] Measure FP, FCP and FMP for Foreground Tab during Session Restore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 2930013005: [Tab Metrics] Measure FP, FCP and FMP for Foreground Tab during Session Restore (Closed)

Patch Set: Fix tab_manager null on Android. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

index ce05d706ecad1940e87d4ac1c8d9f1545e771679..4e5482ecc1c97c4cc7b9e97244fcfd6b6086382d 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

@@ -35,6 +35,7 @@

#include "chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h"

+#include "chrome/browser/page_load_metrics/observers/session_restore_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h"

@@ -132,6 +133,11 @@ void PageLoadMetricsEmbedder::RegisterObservers(

web_contents_);

if (loading_predictor_observer)

tracker->AddObserver(std::move(loading_predictor_observer));

+ std::unique_ptr<page_load_metrics::PageLoadMetricsObserver>

+ session_restore_foreground_tab_observer =

+ SessionRestorePageLoadMetricsObserver::CreateIfNeeded();

+ if (session_restore_foreground_tab_observer)

+ tracker->AddObserver(std::move(session_restore_foreground_tab_observer));

} else {

std::unique_ptr<page_load_metrics::PageLoadMetricsObserver>

prerender_observer =