Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2996)

Unified Diff: chrome/browser/page_load_metrics/observers/session_restore_page_load_metrics_observer.h

Issue 2930013005: [Tab Metrics] Measure FP, FCP and FMP for Foreground Tab during Session Restore (Closed)
Patch Set: Fix tab_manager null on Android. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/session_restore_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/session_restore_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/session_restore_page_load_metrics_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..948cea6648391278319a3c5d0b8e583170986ef9
--- /dev/null
+++ b/chrome/browser/page_load_metrics/observers/session_restore_page_load_metrics_observer.h
@@ -0,0 +1,59 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_SESSION_RESTORE_PAGE_LOAD_METRICS_OBSERVER_H_
+#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_SESSION_RESTORE_PAGE_LOAD_METRICS_OBSERVER_H_
+
+#include <memory>
+
+#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
+#include "chrome/browser/resource_coordinator/tab_manager.h"
+
+namespace internal {
+
+extern const char kHistogramSessionRestoreForegroundTabFirstPaint[];
+extern const char kHistogramSessionRestoreForegroundTabFirstContentfulPaint[];
+extern const char kHistogramSessionRestoreForegroundTabFirstMeaningfulPaint[];
+
+} // namespace internal
+
+// Record page load metrics of foreground tabs during session restore.
+class SessionRestorePageLoadMetricsObserver
+ : public page_load_metrics::PageLoadMetricsObserver {
+ public:
+ SessionRestorePageLoadMetricsObserver() {}
+
+ // We only care about tabs created when session restore is loading tabs.
+ // We also count new page loads in the intial foregrounded tab.
+ // After switching to a different tab, no more page load metrics are recorded.
+ static std::unique_ptr<SessionRestorePageLoadMetricsObserver>
+ CreateIfNeeded();
+
+ // PageLoadMetricsObserver implementation:
+ ObservePolicy OnStart(content::NavigationHandle* navigation_handle,
+ const GURL& currently_committed_url,
+ bool started_in_foreground) override;
+
+ ObservePolicy OnCommit(content::NavigationHandle* navigation_handle,
+ ukm::SourceId source_id) override;
+ ObservePolicy OnHidden(
+ const page_load_metrics::mojom::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) override;
+
+ void OnFirstPaintInPage(
+ const page_load_metrics::mojom::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& extra_info) override;
+
+ void OnFirstContentfulPaintInPage(
+ const page_load_metrics::mojom::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& extra_info) override;
+
+ void OnFirstMeaningfulPaintInMainFrameDocument(
+ const page_load_metrics::mojom::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& extra_info) override;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(SessionRestorePageLoadMetricsObserver);
+};
+#endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_SESSION_RESTORE_PAGE_LOAD_METRICS_OBSERVER_H_

Powered by Google App Engine
This is Rietveld 408576698